Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecal PayloadInspector for Pedestals and ChannelStatus #18647

Merged

Conversation

depasse
Copy link
Contributor

@depasse depasse commented May 9, 2017

Ecal PayloadInspector for Pedestals and ChannelStatus with magic numbers replaced by constant expressions

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

A new Pull Request was created by @depasse for master.

It involves the following packages:

CondCore/EcalPlugins

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @argiro this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@franzoni
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19712/console Started: 2017/05/10 11:46

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18647/19712/summary.html

Comparison Summary:

  • You potentially added 193 lines to the logs
  • Reco comparison results: 3361 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1830338
  • DQMHistoTests: Total failures: 48159
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1781999
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@ggovi
Copy link
Contributor

ggovi commented May 11, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f78dcf4 into cms-sw:master May 11, 2017
@depasse depasse deleted the EcalPayloadInspector_Pedestals_ChannelStatus_v2 branch February 14, 2018 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants