GEM and ME0 realistic digitizer updates #18660
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| #ifndef ME0OBJECTS_ME0DIGISIMLINK_H | ||
|
There was a problem hiding this comment. until ME0DigiSimLink diverges from GEMDigiSimLink, please just define a typedef. There was a problem hiding this comment. ME0DigiSimLink is now #include "SimDataFormats/GEMDigiSimLink/interface/GEMDigiSimLink.h" typedef GEMDigiSimLink ME0DigiSimLink; |
||
| #define ME0OBJECTS_ME0DIGISIMLINK_H | ||
|
|
||
| #include <utility> | ||
| #include "DataFormats/GeometryVector/interface/LocalPoint.h" | ||
| #include "DataFormats/GeometryVector/interface/LocalVector.h" | ||
| #include "SimDataFormats/EncodedEventId/interface/EncodedEventId.h" | ||
|
|
||
| class ME0DigiSimLink | ||
| { | ||
| public: | ||
| ME0DigiSimLink(std::pair<unsigned int, int> digi, Local3DPoint entryPoint, LocalVector momentumAtEntry, | ||
| float timeOfFlight, float energyLoss, int particleType, unsigned int detUnitId, unsigned int trackId, | ||
| EncodedEventId eventId, unsigned short processType) | ||
| { | ||
|
|
||
| _entryPoint = entryPoint; | ||
| _momentumAtEntry = momentumAtEntry; | ||
| _timeOfFlight = timeOfFlight; | ||
| _energyLoss = energyLoss; | ||
| _particleType = particleType; | ||
| _detUnitId = detUnitId; | ||
| _trackId = trackId; | ||
| _eventId = eventId; | ||
| _processType = processType; | ||
| _digi = digi; | ||
| } | ||
|
|
||
| ME0DigiSimLink() {;} | ||
|
|
||
| ~ME0DigiSimLink() {;} | ||
|
|
||
| unsigned int getStrip() const {return _digi.first;} | ||
| unsigned int getBx() const{return _digi.second;} | ||
| Local3DPoint getEntryPoint() const{return _entryPoint;} | ||
| LocalVector getMomentumAtEntry() const{return _momentumAtEntry;} | ||
| float getTimeOfFlight() const{return _timeOfFlight;} | ||
| float getEnergyLoss() const{return _energyLoss;} | ||
| int getParticleType() const{return _particleType;} | ||
| unsigned int getDetUnitId() const{return _detUnitId;} | ||
| unsigned int getTrackId() const{return _trackId;} | ||
| EncodedEventId getEventId() const{return _eventId;} | ||
| unsigned short getProcessType() const{return _processType;} | ||
|
|
||
| inline bool operator<(const ME0DigiSimLink& other) const{return getStrip() < other.getStrip();} | ||
|
|
||
| private: | ||
| std::pair<unsigned int, int> _digi; | ||
|
|
||
| Local3DPoint _entryPoint; | ||
| LocalVector _momentumAtEntry; | ||
| float _timeOfFlight; | ||
| float _energyLoss; | ||
| int _particleType; | ||
| unsigned int _detUnitId; | ||
| unsigned int _trackId; | ||
| EncodedEventId _eventId; | ||
| unsigned short _processType; | ||
|
|
||
| }; | ||
| #endif | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| #include "SimDataFormats/GEMDigiSimLink/interface/ME0DigiSimLink.h" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we settle on some common naming so that (local) reco configs do not get perturbed frequently just because of some internal DIGI-step reorganization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slava77 After this PR no more name changes are foreseen. The naming that is proposed is similar to the other muon digitizers
simMuonME0DigisvssimMuonRPCDigisorsimMuonGEMDigis,simMuonCSCDigisandsimMuonDTDigisfor realistic digis.simMuonME0PadDigisvssimMuonGEMPadDigisfor pads. Pseudo digis now have the stringPseudoin them to distinguish them from real digis. Re-digitized pseudo digis for Muon TDR studies are calledsimMuonME0PseudoReDigis. This naming convention was agreed upon with other GEM/ME0 developers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my education, could you briefly summarize "pseudo" and "re"? (pseudo means smeared, and "re" means?) -perhaps the word "sim" needs to be dropped at some point along this chain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pseudo means that the digis are of type ME0DigiPreReco. Real digis are of type ME0Digi. The pseudo digitization sequence for ME0 was introduced for performance studies (deciding layers, eta partitions, strips) for the Muon Upgrade TDR. This sequence will be taken out of the main digi step in the future. The real ME0 digi sequence is what will be used to build ME0 triggers and for continued ME0 performance studies.