Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Calibration for D11 Geometry #18663

Merged
merged 1 commit into from May 17, 2017

Conversation

atricomi
Copy link
Contributor

New ClusterShape calibration files have been created to take into account the new pixel barrel orientation in T5 Tracker Upgrade Geometry
Default WP is 99.9% efficiency/layer
Also Calibration for 99.5% is available for test purposes

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @atricomi (Alessia Tricomi) for master.

It involves the following packages:

RecoPixelVertexing/PixelLowPtUtilities

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented May 10, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19720/console Started: 2017/05/10 15:52

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18663/19720/summary.html

Comparison Summary:

  • You potentially added 45 lines to the logs
  • Reco comparison results: 2943 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1830338
  • DQMHistoTests: Total failures: 40837
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1789321
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@kpedro88
Copy link
Contributor

assign upgrade

@cmsbuild
Copy link
Contributor

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

@VinInn
Copy link
Contributor

VinInn commented May 14, 2017

this is D11 with this PR vs D13 w/o (ttbar PU200)
http://innocent.home.cern.ch/innocent/RelVal/pu200D11_ori/plots_highPurity/effandfake1.pdf

@VinInn
Copy link
Contributor

VinInn commented May 14, 2017

as a side effect in #18728 you can see singlemuons as well for this PR (blue squares)

@slava77
Copy link
Contributor

slava77 commented May 15, 2017

@VinInn
please add a comparison of D11 without and with this PR.
Comparison of D13(without) with D11(with) is not easy to interpret as being useful for D11.

@slava77
Copy link
Contributor

slava77 commented May 17, 2017

+1

for #18663 7dafeac

  • change in pixel cluster shape for phase 2; the same as in 91X
  • jenkins tests pass and comparisons with baseline show differences only in phase-2 workflows
  • relying on supporting material provided with the pull request and additional tests done in 91X as a part of the signoff

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 42ed42e into cms-sw:master May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants