Small bugfix and several new features for the geometry comparison tool #18699
Conversation
…ifts and absolute positions added, ordering of displayed comparison changed, cout statements replaced by edm::LogInfo
|
A new Pull Request was created by @cschomak for master. It involves the following packages: Alignment/OfflineValidation @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
| @@ -266,7 +288,18 @@ void GeometryComparisonPlotter::MakePlots (vector<TString> x, // axes to combine | |||
| _window_width, | |||
| _window_height); | |||
| c_global[ic]->Divide(x.size(),y.size()); | |||
|
|
|||
| if (_make_profile_plots == "true") { | |||
There was a problem hiding this comment.
@cschomak is there a reason why a boolean is represented as a string?
There was a problem hiding this comment.
Not really. There were already some booleans represented as string and I did not think about it and stuck to it. I changed them now
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
cmsbuild
added
alca-approved
fully-signed
tests-started
and removed
alca-pending
pending-signatures
tests-pending
labels
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
Fixed bug in absolute position that caused the absolute positions in the GC tool to be slightly off (global position record applied twice, 0.1-0.2 cm effect in 2016 data), relative shifts were not affected
Changed x-axis of the displayed geometry (previously from first "new" alignment, now from the old one)
Added profile plots to get a better feeling for the trends than from the scatter plots alone
Added tables for the mean shifts and absolute positions of the subdetectors
Replaced cout by LogInfo statements