Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate nuclear interactions files for fastsim #18700

Merged
merged 2 commits into from May 15, 2017

Conversation

davidlange6
Copy link
Contributor

Goal - to reduce open files in cmsRun

@smuzaffar - this needs all the data files currently in data-FastSimulation-MaterialEffects to be replaced by this file:
cmsdev02:/build/dlange/CMSSW_9_2_X_2017-05-11-1100/src/FastSimulation/MaterialEffects/data/NuclearInteractions.root

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

FastSimulation/MaterialEffects

@ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented May 11, 2017

@davidlange6 , @ssekmen , probably this problem is the next argument to try switch to FTF FastSim nuclear interaction. Here usage of root for storage of intermediate data is, at least, a strange patern.

@davidlange6
Copy link
Contributor Author

davidlange6 commented May 11, 2017 via email

@smuzaffar
Copy link
Contributor

smuzaffar commented May 15, 2017

@iahmad-khan , can you please takecare of data-FastSimulation-MaterialEffects
By the way, this data is being served from cmsdoc.cern.ch via /afs/cern.ch/cms/data/CMSSW

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#3038

@cmsbuild
Copy link
Contributor

cmsbuild commented May 15, 2017

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3038
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19819/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18700/19819/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3367 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1830696
  • DQMHistoTests: Total failures: 18781
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1811735
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6 davidlange6 merged commit 0c2604c into cms-sw:master May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants