Pr92x L1T UnpackerCaloLayer1 & DQMCaloLayer1 Adjust for Non-present FED data in MC #18703
Conversation
…a LogError, and silence after 5 times.
…a and emulation. The missmatch goes into the DQM histogram towerCountMismatchesPerBx anyhow.
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @rekovic for master. It involves the following packages: DQM/L1TMonitor @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| @@ -168,7 +171,10 @@ L1TCaloLayer1RawToDigi::produce(Event& iEvent, const EventSetup& iSetup) | |||
| const uint64_t *fedRawDataArray = (const uint64_t *) fedRawData.data(); | |||
|
|
|||
| if ( fedRawData.size() == 0 || fedRawDataArray == nullptr ) { | |||
| LogError("L1TCaloLayer1RawToDigi") << "Could not load FED data for " << fed << ", putting empty collections!"; | |||
| if (warnsa<5) { | |||
There was a problem hiding this comment.
Note that this will print the LogInfo 5 times per stream, not just 5 times per job.
@Dr15Jones is there a way to set the default limit on the MessageLogger from within the C++ code ?
In the full process configuration one can do
process.MessageLogger.categories.append("L1TCaloLayer1RawToDigi")
process.MessageLogger.L1TCaloLayer1RawToDigi = cms.untracked.PSet(
limit = cms.untracked.int32( 5 )
)Is there a way to do the same in C++ within the module that will print the messages ?
Something like
if (edm::Service<MessageLogger>().isAvailable())
edm::Service<MessageLogger>()->category("L1TCaloLayer1RawToDigi").setDefaultLimit(5);?
|
+1 |
|
I see now the above comment/question of @fwyzard. Thanks. If there is such a way to control the number of MessageLogger messages within C++, will be happy to change it. |
|
unfortunately printing 5 times (let alone 5*nThreads) does not scale (imagine if all 1000s of modules were programmed with that design). If the error is expected, reduce it to LogDebug. (and how can we not have an unpacker for this stuff?)
… On May 12, 2017, at 9:47 AM, rekovic ***@***.***> wrote:
I see now the above comment/question of @fwyzard. Thanks.
If there is such a way to control the number of MessageLogger messages within C++, will be happy to change it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
…nfo not a LogError, and silence after 5 times." This reverts commit cb8218b.
|
The tests are being triggered in jenkins. |
|
Pull request #18703 was updated. @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again. |
…s in data and emulation. The missmatch goes into the DQM histogram towerCountMismatchesPerBx anyhow." This reverts commit cb4b9f6.
…ta and emulation. The missmatch goes into the DQM histogram towerCountMismatchesPerBx anyhow.
|
please test |
|
The tests are being triggered in jenkins. |
|
Pull request #18703 was updated. @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again. |
Done. |
|
ok, I rephrase.. "how can we not have a packer for this stuff..."
… On May 15, 2017, at 10:04 AM, rekovic ***@***.***> wrote:
@davidlange6
unfortunately printing 5 times (let alone 5*nThreads) does not scale (imagine if all 1000s of modules were programmed with that design). If the error is expected, reduce it to LogDebug. (and how can we not have an unpacker for this stuff?)
Done.
It is not that we don't have the unpacker. It is the packers that we are missing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@davidlange6 |
|
@davidlange6 Goal is to have it in 92X. |
|
@dmitrijus can you please review & comment/sign this and @18703. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@rekovic - so this does reduce the L1 noise - things still remaining that seem to happen every event.. %MSG-e L1TStage2CaloLayer2Offline: L1TStage2CaloLayer2Offline:l1tStage2CaloLayer2OfflineDQMEmu 16-May-2017 10:41:04 CEST Run: 1 Event: 13 |
92x: This fixes the error messages reported by @davidlange6 in #18085 (comment), which arise only in MC, wherewe still don't pack data for CaloLayer1.
Once the CaloLayer1 packer developed, this will not be an issue.
With this PR, the unpacker issues a LogInfo if FED data not found, and is silenced after 5 times.
Again, this only happens when running on RAW MC.
Also the DQM CaloLayer1 issues a LogInfo in case the emulator of CaloLayer1 and unpacked raw data disagree. In case of MC, they do as unpacked data collection is empty.