Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr91x L1T UnpackerCaloLayer1 & DQMCaloLayer1 Adjust for Non-present FED data in MC #18706

Merged
merged 6 commits into from May 16, 2017
Merged

Pr91x L1T UnpackerCaloLayer1 & DQMCaloLayer1 Adjust for Non-present FED data in MC #18706

merged 6 commits into from May 16, 2017

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented May 12, 2017

This is the 91x version of #18703.

@rekovic
Turn LogError to LogInfo in case of different number of towers in dat…
e54aac8 
…a and emulation. The missmatch goes into the DQM histogram towerCountMismatchesPerBx anyhow.
@rekovic
If cannot find FED data for caloLayer1RawToDigi, issue a LogInfo not …
52d4f4d 
…a LogError, and silence after 5 times.
@rekovic
Copy link
Contributor Author

rekovic commented May 12, 2017

please test

@cmsbuild cmsbuild added this to the CMSSW_9_1_X milestone May 12, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented May 12, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19785/console Started: 2017/05/12 10:26

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for CMSSW_9_1_X.

It involves the following packages:

DQM/L1TMonitor
EventFilter/L1TXRawToDigi

@dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko, @thomreis this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: 52d4f4d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18706/19785/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18706/19785/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3281 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831084
  • DQMHistoTests: Total failures: 33273
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1797631
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@rekovic
Revert "If cannot find FED data for caloLayer1RawToDigi, issue a LogI…
f1b6be7 
…nfo not a LogError, and silence after 5 times."

This reverts commit 52d4f4d.
@rekovic
Revert "Turn LogError to LogInfo in case of different number of tower…
b1ffd26 
…s in data and emulation. The missmatch goes into the DQM histogram towerCountMismatchesPerBx anyhow."

This reverts commit e54aac8.
@rekovic
In case of MC RAW, cannot find FED data for caloLayer1RawToDigi. This…
e90a54b 
… is a known feature that happpens only in that case, and which will be fixed with the introduction of a packer (in makings). So turn LogError to LogDebug to avoid overfilling LogMesseg in MC RAW2DIGI jobs."
@rekovic
Turn LogError to LogDebug in case of different number of towers in da…
22121f3 
…ta and emulation. The missmatch goes into the DQM histogram towerCountMismatchesPerBx anyhow.
@rekovic
Copy link
Contributor Author

rekovic commented May 15, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 15, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19818/console Started: 2017/05/15 10:02

@cmsbuild
Copy link
Contributor

Pull request #18706 was updated. @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

@thomreis thomreis mentioned this pull request May 15, 2017
Closed
@rekovic
Copy link
Contributor Author

rekovic commented May 15, 2017

@dmitrijus can you please review & comment/sign?

@cmsbuild
Copy link
Contributor

+1
Tested at: 22121f3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18706/19818/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18706/19818/summary.html

Comparison Summary:

  • You potentially added 28 lines to the logs
  • Reco comparison results: 1692 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831050
  • DQMHistoTests: Total failures: 56553
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1774317
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6 davidlange6 merged commit 06ce54b into cms-sw:CMSSW_9_1_X May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-pending l1-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_9_1_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rekovic @cmsbuild @davidlange6