Fix Clang errors (undefined references) #18710
Conversation
The patch resolves issue with Clang compiler. N3690 (should be C++11 standard) and latest draft N4567, 9.4.2/3 ... The member shall still be defined in a namespace scope if it is odr-used (3.2) in the program and the namespace scope definition shall not contain an initializer. 9.4.2/4 talks about how const static data members are being handled. Also standard says that no diagnostic is required by compiler. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for master. It involves the following packages: DQM/CTPPS @perrotta, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1 |
cmsbuild
added
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
@perrotta here it is https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc530/CMSSW_9_2_CLANG_X_2017-05-14-2300/RecoEgamma/EgammaElectronAlgos You can find them by selecting CMSSW_9_2_CLANG_X in showIB page (top nav bar). |
|
+1 |
The patch resolves issue with Clang compiler.
N3690 (should be C++11 standard) and latest draft N4567, 9.4.2/3
...
The member shall still be defined in a namespace scope if it
is odr-used (3.2) in the program and the namespace scope definition
shall not contain an initializer.
9.4.2/4 talks about how const static data members are being handled.
Also standard says that no diagnostic is required by compiler.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch