CTPPS: DQM configuration fix #18718
CTPPS: DQM configuration fix #18718
Conversation
|
A new Pull Request was created by @jan-kaspar for master. It involves the following packages: DQM/CTPPS @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@forthommel : I can do, but this is not a reco PR. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Many thanks, @perrotta! |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@dmitrijus, @vanbesien, can we help you somehow for your review? |
|
@jan-kaspar @forthommel could you please make a back port PR for 91X asap? thanks. Tomas (DQM). Broen and Dmitrijus will be available Friday the soonest. |
|
Pull request #18718 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
I've added a comment, which has to be addressed. |
|
Hi @dmitrijus |
| @@ -12,15 +12,14 @@ | |||
| # for testing in lxplus | |||
| process.load("DQM.Integration.config.fileinputsource_cfi") | |||
| process.source.fileNames = cms.untracked.vstring( | |||
| 'file:/afs/cern.ch/user/j/jkaspar/public/run273062_ls0001-2_stream.root', | |||
| #'root://eostotem.cern.ch//eos/totem/user/j/jkaspar/04C8034A-9626-E611-9B6E-02163E011F93.root' | |||
There was a problem hiding this comment.
This won't work online. You must use "DQM.Integration.config.inputsource_cfi", the "fileinputsource_cfi" is for testing/development only!
Also, for testing, you can also use (with inputsource_cfi): cmsRun <my_online_dqm_client> inputFiles="a.root,b.root"
There was a problem hiding this comment.
Hi Dmitrijus,
the lines you talk about would not be executed since the test variable is set to False:
https://github.com/CTPPS/cmssw/blob/07882d194c34f8cf39ea91471c3f9ca176af35bc/DQM/Integration/python/clients/ctpps_dqm_sourceclient-live_cfg.py#L5
Nevertheless, if you prefer, I can remove the "test" block completely - let me know.
There was a problem hiding this comment.
Ah, I missed the if block, sorry :(
|
I forgot to press "submit" button, you should see it now. |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
Several fixes for CTPPS DQM configuration. Important for commissioning/calibration at the LHC restart.