Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pileup jet ID for JPT #1872

Merged
merged 3 commits into from Dec 19, 2013
Merged

Pileup jet ID for JPT #1872

merged 3 commits into from Dec 19, 2013

Conversation

rkogler
Copy link
Contributor

@rkogler rkogler commented Dec 18, 2013

Pileup jet ID for JPT jets included. This update also includes weight files for the standard pileup jet ID, which are now stored in an external package (and downloaded through download.url).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rkogler (Roman Kogler) for CMSSW_7_0_X.

Pileup jet ID for JPT

It involves the following packages:

RecoJets/JetProducers

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

thspeer
thspeer reviewed Dec 18, 2013
View reviewed changes
RecoJets/JetProducers/plugins/PileupJPTJetIdProducer.cc
//
// Original Author: Olga Kodolova,40 R-A12,+41227671273,
// Created: Fri Jan 11 15:30:47 CEST 2013
// $Id: PileupJPTJetIdProducer.cc,v 1.1 2013/03/27 17:42:09 rkogler Exp $
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove CVS tags

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1872/1847/summary.html

thspeer
thspeer reviewed Dec 19, 2013
View reviewed changes
RecoJets/JetProducers/plugins/PileupJPTJetIdProducer.cc

// ------------------------------------------------------------------------------------------
void
PileupJPTJetIdProducer::beginRun(edm::Run&, edm::EventSetup const&)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove begin/end Run/Job from .h and .cc , since they are empty

@cmsbuild
Copy link
Contributor

Pull request #1872 was updated. @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1872/1865/summary.html

@thspeer
Copy link
Contributor

thspeer commented Dec 19, 2013

+1
Tested 2d854b3 in CMSSW_7_0_X_2013-12-18-0200_1872
Since this is not used in the standard reco sequence, there is no difference in reco, based on !RelMon and reco script,
The next version should use GBRForest instead TMVA and the weight files should go into the DB.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes (tests are also fine). @ktf can you please take care of it?

ktf added a commit that referenced this pull request Dec 19, 2013
@ktf
Merge pull request #1872 from rkogler/jet_dev
344d507 
Reco update -- Pileup jet ID for JPT
@ktf ktf merged commit 344d507 into cms-sw:CMSSW_7_0_X Dec 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fully-signed reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_0_0_pre11
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rkogler @cmsbuild @thspeer @ktf