CSC TP bugfixes for high PU running

[dildick]

Last week Stefan Piperov reported that the PU-samples with the D12 geometry crash with an error rate of 85% in the DIGI step with error

cmsRun1
Fatal Exception (Exit Code: 8001)
An exception of category 'InvalidDetId' occurred while
   [0] Processing  Event run: 1 lumi: 181 event: 9005 stream: 0
   [1] Running path 'L1simulation_step'
   [2] Calling method for module 
CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
Exception Message:
GEMDetId ctor: det: 0 subdet: 0 is not a valid GEM id

After investigation it was found that the pad DetIds sometimes get corrupted. I put in place a few checks to ensure that the constructor is not called when the DetId is not a GEMDetId.

This update needs to be included in 91X and 92X.

@calabria

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @kreczko, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[calabria]

@kpedro88 FYI
@dildick please send the same to 91X

[kpedro88]

please test

[kpedro88]

assign upgrade

[cmsbuild]

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19840/console Started: 2017/05/15 21:26

[cmsbuild]

+1
Tested at: c35a6fa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18743/19840/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18743/19840/summary.html

Comparison Summary:

• You potentially added 1176 lines to the logs
• Reco comparison results: 1713 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1829394
• DQMHistoTests: Total failures: 22842
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1806372
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[rekovic]

+1

[rekovic]

@dildick What does this mean for the events that did not crash? Was the DetID properly set?

[dildick]

I believe so. I have not yet found the root cause of the corruption. But this prevents the run functions in the CSC-GEM Motherboards from crashing unnecessarily.

[kpedro88]

@dildick please reduce the number of messages printed; this PR added 1000+ lines to the log for 2023D8 step3, all like this:

%MSG-e GEMCoPadDigiValidation:  GEMCoPadDigiValidation:gemCoPadValidation  15-May-2017 22:11:02 CEST Run: 1 Event: 3
 Re 1 Ri 1 St 2 La 0 Ch 3 Ro 4  : This part can not load from GEMGeometry // Original Re 1 Ri 1 St 2 La 0 Ch 3 Ro 0  station : 2
%MSG

[dildick]

@kpedro88 The issue originates here:

cmssw/Validation/MuonGEMDigis/src/GEMCoPadDigiValidation.cc

Lines 121 to 129 in df5afe9

	GEMDetId roId = GEMDetId(re, id.ring(), st, la, chamber, digiItr->roll());
	Short_t nroll = roId.roll();
	LogDebug("GEMCoPadDigiValidation")<<"roId : "<<roId;
	const GeomDet* gdet = GEMGeometry_->idToDet(roId);
	if ( gdet == nullptr) {
	edm::LogError("GEMCoPadDigiValidation")<<roId<<" : This part can not load from GEMGeometry // Original"<<id<<" station : "<<st;
	edm::LogError("GEMCoPadDigiValidation")<<"Getting DetId failed. Discard this gem copad hit.Maybe it comes from unmatched geometry between GEN and DIGI.";
	continue;
	}

. I'll provide a fix later today.

[cmsbuild]

Pull request #18743 was updated. @kpedro88, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

[dildick]

This should address the issue.

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19888/console Started: 2017/05/16 21:33

[cmsbuild]

+1
Tested at: 2f28d9b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18743/19888/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18743/19888/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 1716 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1833858
• DQMHistoTests: Total failures: 53626
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1780052
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[kpedro88]

+1