Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[92X] Fix pixel barycentre tool #18754

Merged
merged 6 commits into from May 17, 2017

Conversation

ghellwig
Copy link

  • fix use case of alignment producer that is needed for the bary-centre tool
  • make the tool geometry independent
  • streamline tool script
  • added a unit test for the tool

@ghellwig
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19853/console Started: 2017/05/15 22:47

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ghellwig (Gregor Mittag) for master.

It involves the following packages:

Alignment/CommonAlignmentProducer
Alignment/MillePedeAlignmentAlgorithm
Alignment/TrackerAlignment

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @tocheng, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@ghellwig
Copy link
Author

type bugfix

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18754/19853/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3361 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1829394
  • DQMHistoTests: Total failures: 47225
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1781989
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@ghellwig
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19867/console Started: 2017/05/16 18:45

@cmsbuild
Copy link
Contributor

Pull request #18754 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@franzoni
Copy link

no unexpected changes observed in the tests available for 10024.0_TTbar , 136.731_RunSinglePh2016B and 10042.0_ZMM
(the commit added after won't change any of the official sequences)

@franzoni
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18754/19867/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3324 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833892
  • DQMHistoTests: Total failures: 33213
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1800499
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e277a0f into cms-sw:master May 17, 2017
@ghellwig ghellwig deleted the pixel-barycentre-tool-fix_92X branch May 17, 2017 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants