Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameterSet retrieval function to Event #18772

Merged
merged 1 commit into from May 17, 2017

Conversation

Dr15Jones
Copy link
Contributor

Added the method parameterSet to the base class for all Events, edm::EventBase. This function guarantees that the ParameterSetRegistry has already been filled before attempting to do a lookup.

Added the method parameterSet to the base class for all Events, edm::EventBase. This function guarantees that the ParameterSetRegistry has already been filled before attempting to do a lookup.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DataFormats/FWLite
FWCore/Common
FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19884/console Started: 2017/05/16 21:09

@Dr15Jones
Copy link
Contributor Author

I'm anticipating that clang might give warnings if I missed a place where I should have added override.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18772/19884/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1693 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833892
  • DQMHistoTests: Total failures: 43204
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1790508
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 415b829 into cms-sw:master May 17, 2017
@Dr15Jones Dr15Jones deleted the parameterSetFromEvent branch May 18, 2017 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants