Phase2-hgx82 Add the required changes to utilize wafers defined as ExtrudedPolygon

[bsunanda]

Extruded polygon is a recommended shape by G4 team to replace Polyhedra and Boolean utilizing Polyhedra. This is introduced for HGCal geometry

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19887/console Started: 2017/05/16 21:30

[cmsbuild]

-1

Tested at: 39f66d9

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18774/19887/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-16-1100/src/Geometry/HGCalCommonData/plugins/HGCalNumberingInitialization.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-16-1100/src/Geometry/HGCalCommonData/plugins/HGCalParametersESModule.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-16-1100/src/Geometry/HGCalCommonData/plugins/FastTimeNumberingInitialization.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-16-1100/src/Geometry/HGCalCommonData/plugins/FastTimeParametersESModule.cc 
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-16-1100/src/Geometry/CaloTopology/src/HGCalTopology.cc:1:0:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-16-1100/src/Geometry/CaloTopology/interface/HGCalTopology.h:88:3: error: 'HGCalGeometryMode' does not name a type
   HGCalGeometryMode geomMode() const {return mode_;}
   ^
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-16-1100/src/Geometry/CaloTopology/interface/HGCalTopology.h:134:3: error: 'HGCalGeometryMode' does not name a type
   HGCalGeometryMode           mode_;
   ^


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

Pull request #18774 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @kpedro88, @vanbesien, @davidlange6 can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19897/console Started: 2017/05/16 22:40

[cmsbuild]

+1
Tested at: 0daa118
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18774/19897/summary.html

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20434/console Started: 2017/06/08 18:03

[cmsbuild]

Pull request #18774 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @kpedro88, @vanbesien, @davidlange6 can you please check and sign again.

[bsunanda]

@ianna @civanch @kpedro88 @dmitrijus @davidlange6 I removed two casting statements as suggested by David. This is a PR waiting former than 3 weeks. Could you approve this at the earliest?

[kpedro88]

+1

[cmsbuild]

+1
Tested at: 556d2d0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18774/20434/summary.html

[cmsbuild]

Comparison job queued.

[ianna]

+1

[civanch]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18774/20434/summary.html

Comparison Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1867702
• DQMHistoTests: Total failures: 5290
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1862239
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files