Fix includes/forward declarations in FWCore/Framework #18782
Conversation
We use size_t here, so we also need to include cstddef to make this header compile.
The header currently doesn't compile on it's own when included because of the referenced to ConfigurationDescriptions. This patch adds the forward declaration to make it compile.
The forward declaration which is needed to make this header to compile declares a class named "TriggersNameService", but the class is actually called "TriggerNamesService".
We need the definition of both classes in this header because we call member functions from those classes here, but right now we only have two forward declarations. This patch replaces both forward declarations with the proper includes to make the header compile on it's own.
|
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Part of the work to solve the issue #15248 |
|
Please test |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Comparison job queued. |
|
+1 |
|
Comparison is ready Comparison Summary:
|
Multiple headers in FWCore/Framework currently don't compile. This PR fixes this by correcting typos, including the relevant headers and adding the relevant forward declarations.