New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing includes to makeGlobal.h #18794
Conversation
We have to include memory because we use unique_ptr's in this file. The include to "dummy_helpers.h" is necessary because we use dummy_ptr() and the forward declaration for ParameterSet is necessary because we use that as the function parameters.
Part of the work to solve the issue #15248 |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
Comparison job queued. |
+1 |
Comparison is ready Comparison Summary:
|
We have to include memory because we use unique_ptr's in this file.
The include to "dummy_helpers.h" is necessary because we use dummy_ptr()
and the forward declaration for ParameterSet is necessary because
we use that as the function parameters.