Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing includes to makeGlobal.h #18794

Merged
merged 1 commit into from May 17, 2017

Conversation

Teemperor
Copy link
Contributor

We have to include memory because we use unique_ptr's in this file.
The include to "dummy_helpers.h" is necessary because we use dummy_ptr()
and the forward declaration for ParameterSet is necessary because
we use that as the function parameters.

We have to include memory because we use unique_ptr's in this file.
The include to "dummy_helpers.h" is necessary because we use dummy_ptr()
and the forward declaration for ParameterSet is necessary because
we use that as the function parameters.
@Teemperor
Copy link
Contributor Author

Part of the work to solve the issue #15248

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

Please test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19925/console Started: 2017/05/17 13:50

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 412f27b into cms-sw:master May 17, 2017
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18794/19925/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1646 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833867
  • DQMHistoTests: Total failures: 27811
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1805876
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@Teemperor Teemperor deleted the MissingIncludeMakeGlobal.h branch December 19, 2017 08:47
@Teemperor Teemperor restored the MissingIncludeMakeGlobal.h branch December 19, 2017 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants