SubProcess no longer an OutputModule #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er describes its purpose
…we do not have to make a temporary edm::Event
…o reuse elsewhere.
…complished by moving common code to different class files
|
The following categories have been signed by chrjones (a.k.a. @Dr15Jones on GitHub): Core @cms-git-visualization, @cms-git-core, @cms-git-geometry |
|
Hi Christopher, I took CMSSW_7_0_X_2013-07-28-0200, pulled these changes, and when I was building I noticed that the package Calibration/EcalCalibAlgos is complaining about the renaming of CachedProducts.h This is the error message that I got: >> Compiling edm plugin /build/dmendezl/CMSSW_7_0_X_2013-07-28-0200/src/FWCore/Modules/src/NavigateEventsLooper.cc In file included from /build/dmendezl/CMSSW_7_0_X_2013-07-28-0200/src/Calibration/EcalCalibAlgos/src/ZeeCalibration.cc:51:0: /build/dmendezl/CMSSW_7_0_X_2013-07-28-0200/poison/FWCore/Framework/interface/CachedProducts.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. gmake: *** [tmp/slc5_amd64_gcc472/src/Calibration/EcalCalibAlgos/src/CalibrationEcalCalibAlgos/ZeeCalibration.o] Error 1 gmake: *** Waiting for unfinished jobs.... I looked into the file Calibration/EcalCalibAlgos/src/ZeeCalibration.cc and in the line 51 there is an include with the old file name: "#include FWCore/Framework/interface/CachedProducts.h" I changed this line to: "#include "FWCore/Framework/interface/TriggerResultsBasedEventSelector.h" And now it works. Could you include this in your pull request? |
…that file is now gone
|
I was able to find an even easier solution, I removed that include all together since it wasn't needed by that file. I was going to re-sign this pull but the Topic Collector is failing again. Please go ahead and retest. |
|
Hi Christopher, I just finished running the tests. All passed, I will merge it as you requested. |
nclopezo
added a commit
that referenced
this pull request
Jul 29, 2013
SubProcess no longer an OutputModule
tahuang1991
added a commit
to tahuang1991/cmssw
that referenced
this pull request
Sep 15, 2014
…CH16 modify the gemdphi calculation function to assign valid gemdphi to LCT w...
nclopezo
pushed a commit
to nclopezo/cmssw
that referenced
this pull request
Nov 21, 2014
Add extra config.map variable.
parbol
pushed a commit
to parbol/cmssw
that referenced
this pull request
Mar 5, 2015
More susy leptonic updates for Phys14
arizzi
added a commit
to arizzi/cmssw
that referenced
this pull request
Sep 30, 2015
from CERN-PH-CMG/cmg-cmssw/pull/501: implement the Spring15 Effective Areas for 25ns and 50ns
cmsbuild
pushed a commit
that referenced
this pull request
Aug 9, 2018
Changing trigger backfill value
fwyzard
added a commit
to fwyzard/cmssw
that referenced
this pull request
Oct 31, 2018
If no CUDA devices are present, skip the tests and return a success status, instead of failing.
mandrenguyen
added a commit
to mandrenguyen/cmssw
that referenced
this pull request
Mar 17, 2019
emily-tsai11
pushed a commit
to emily-tsai11/cmssw
that referenced
this pull request
Nov 15, 2022
* kf bug fixes, f/w sync. * updated reduced dat files and channel assignment. * correct channel assignment. * reduced dat files deleted.
rgoldouz
pushed a commit
to rgoldouz/cmssw
that referenced
this pull request
Dec 15, 2022
* kf bug fixes, f/w sync. * updated reduced dat files and channel assignment. * correct channel assignment. * reduced dat files deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To facilitate the addition of the new thread safe module types, the SubProcess class no longer inherits from edm::OutputModule. It was never actually used as an OutputModule and only wanted to share some of its implementation. The common code was moved different source files to allow sharing.