Add fake trajectory to PixelTracks

[JanFSchulte]

Add a fake trajectory and dummy chi2 values to the PixelTracks class so that pixel tracks can be used with classes such as TrackListMerger. Needed for mitigation of the effect of non-functioning modules in the new pixel detector

[cmsbuild]

A new Pull Request was created by @JanFSchulte (Jan-Frederik Schulte) for master.

It involves the following packages:

RecoPixelVertexing/PixelTrackFitting

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19948/console Started: 2017/05/18 00:03

[cmsbuild]

+1
Tested at: f92a8df
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18816/19948/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18816/19948/summary.html

Comparison Summary:

• You potentially added 26 lines to the logs
• Reco comparison results: 1672 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1833901
• DQMHistoTests: Total failures: 53557
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1780164
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[fwyzard]

please comment or sign and merge ASAP

[slava77]

sorry for the delay. I should provide feedback or sign later today.

[fwyzard]

thanks (I just discovered we need this PR)

[slava77]

+1

for #18816 f92a8df

• code change sets default trajectory params and chi2 per hit in PixelTrackProducer. This is used mainly in HLT, but also in RecoHI/HiTracking. The cost for HI reco would be some small increase in memory (o(1MB)/thread corresponding to ~100 bytes/track and at worst a few K tracks).
• jenkins tests pass and comparisons with baseline show no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[cmsbuild]

Pull request #18816 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20057/console Started: 2017/05/24 14:14

[cmsbuild]

+1
Tested at: 438c6fb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18816/20057/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18816/20057/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 95 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1832990
• DQMHistoTests: Total failures: 32808
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1800002
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[slava77]

+1

for #18816 438c6fb

• updated since last signoff following comments from @davidlange6 to initialize vectors in a constructor rather than in a loop
• jenkins tests pass; no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1