Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HGCAL trigger fixes, optimizations and cleaning #18861

Merged
merged 25 commits into from May 23, 2017
Merged

HGCAL trigger fixes, optimizations and cleaning #18861

merged 25 commits into from May 23, 2017

Conversation

jbsauvan
Copy link
Contributor

  • Bug fixes in the trigger cell calibration and in the 3D cluster linking
  • Code optimization reducing by a factor 2 to 4 the processing time of the HGCAL trigger primitive generation
  • Add a cluster-level global calibration to put the EM response around 1 (some small dependency with eta and pT remains)
  • Cleaning of config files and updates of the default parameters

jbsauvan and others added 25 commits April 28, 2017 16:24
@jbsauvan
Put back neighbor data file until integrated in release
586509e
@jbsauvan
Merge pull request #102 from PFCal-dev/backport-integration
a7183ac 
Propagate integration updates into the development branch
@jbsauvan
Merged hgc-tpg-devel-CMSSW_9_1_0_pre2 from repository PFCal-dev
c5d00e1
@jbsauvan
Update config relval sample
648892e
@jbsauvan
Remove neighbor mapping files
f5e48eb
@jbsauvan
Fix extremely long loop for 2D clustering
d68ed09
@jbsauvan
Optimize trigger cell validity checking
c07e99e
@jbsauvan
Remove useless printouts in HGCalTriggerDigiProducer
3e6a1eb
@jbsauvan
Merge pull request #109 from jbsauvan/optimizations
638a509 
Code optimizations
@jbsauvan
Clean config files
d9dbb65
@jbsauvan
Merge pull request #110 from jbsauvan/update-configs
9e9311e 
Clean config files + remove frontend truncation
@jbsauvan
Fix construction of clusters from constituents
e3ad698
@jbsauvan
Merge pull request #112 from jbsauvan/fix-clustering-nan
59a22ce 
Fix NaN deltaR in clustering
@mastrolorenzo
Fix in calibration chain (thickness cor.) + other older small addition
21b26f9
@mastrolorenzo
fixes-v1
8b84a16
@mastrolorenzo
move log in constructor of HGCalTriggerCellCalibration.cc
25c51ea
@mastrolorenzo
use loop for in the constructor of HGCalTriggerCellCalibration.cc to …
009e535 
…prevent division-by-zero
@mastrolorenzo
minor fix in HGCalTriggerCellCalibration.cc
dd5e702
@mastrolorenzo
added C3d-dedicated global calibration scale factor
1daf8fa
@mastrolorenzo
fixes
38a6bfa
@mastrolorenzo
mass identically 0. in calibrated C3d-4P
74691e8
@jbsauvan
Merge pull request #114 from mastrolorenzo/clustering2DNN_3Dbase_910pre3
2893e83 
Trigger cell calibration fix + add cluster calibration
@jbsauvan
Add clustering threshold before creating collection
447ab38
@jbsauvan
Add default cluster cut of 0.5 GeV
3e8d27e
@jbsauvan
Merge pull request #115 from jbsauvan/tc-cluster-thresholds
e484bd2 
Thresholds on output collections
@cmsbuild cmsbuild added this to the CMSSW_9_2_X milestone May 19, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master.

It involves the following packages:

DataFormats/L1THGCal
L1Trigger/L1THGCal

@cmsbuild, @rekovic, @mulhearn, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @kreczko, @lgray this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 19, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19997/console Started: 2017/05/19 17:37

@jbsauvan jbsauvan mentioned this pull request May 19, 2017
Open
@cmsbuild
Copy link
Contributor

+1
Tested at: e484bd2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18861/19997/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e484bd2
2893e83
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18861/19997/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18861/19997/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18861/19997/summary.html

Comparison Summary:

  • You potentially added 191 lines to the logs
  • Reco comparison results: 3362 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833901
  • DQMHistoTests: Total failures: 34460
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1799261
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@kpedro88
Copy link
Contributor

+1

@rekovic
Copy link
Contributor

rekovic commented May 22, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fa5fc9a into cms-sw:master May 23, 2017
@rekovic rekovic mentioned this pull request Jun 6, 2017
Closed
@jbsauvan jbsauvan mentioned this pull request Nov 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed l1-approved orp-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_9_2_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jbsauvan @cmsbuild @kpedro88 @rekovic @davidlange6 @mastrolorenzo