Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #1739 #1887

Merged
merged 2 commits into from Dec 19, 2013
Merged

Revert #1739 #1887

merged 2 commits into from Dec 19, 2013

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Dec 19, 2013

#1739 introduces a too big performance hit and large printouts. Killing this before it kills the next IB as well.

…ripTrackingRecHitsValid to make them geometry generic adding a bool parameters"

This reverts commit 8a3f369.
…ripTrackingRecHitsValid to make them geometry generic"

This reverts commit 415dc8b.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_0_X.

Revert #1739

It involves the following packages:

Validation/RecoTrack
Validation/TrackerRecHits

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @eliasron can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@deguio
Copy link
Contributor

deguio commented Dec 19, 2013

+1

ktf added a commit that referenced this pull request Dec 19, 2013
@ktf ktf merged commit b465898 into cms-sw:CMSSW_7_0_X Dec 19, 2013
@ktf ktf deleted the revert-1739 branch December 19, 2013 09:26
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants