Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code indention in CTPPSPixelDQMSource #18870

Merged
merged 1 commit into from May 22, 2017
Merged

Fix code indention in CTPPSPixelDQMSource #18870

merged 1 commit into from May 22, 2017

Conversation

Dr15Jones
Copy link
Contributor

gcc 6.3 gave warnings for misleading code indention.

@Dr15Jones
Fix code intention in CTPPSPixelDQMSource
2c3d535 
gcc 6.3 gave warnings for misleading code indention.
@cmsbuild cmsbuild added this to the CMSSW_9_2_X milestone May 20, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DQM/CTPPS

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 20, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20011/console Started: 2017/05/20 17:46

@Dr15Jones
Copy link
Contributor Author

The changes are purely 'cosmetic'

@cmsbuild
Copy link
Contributor

+1
Tested at: 2c3d535
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18870/20011/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Dr15Jones Dr15Jones changed the title Fix code intention in CTPPSPixelDQMSource Fix code indention in CTPPSPixelDQMSource May 20, 2017
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18870/20011/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3312 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833969
  • DQMHistoTests: Total failures: 34146
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1799643
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6 davidlange6 merged commit 3303eb4 into cms-sw:master May 22, 2017
@Dr15Jones Dr15Jones deleted the fixIndentsInCTPPSPixelDQMSource branch May 23, 2017 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_9_2_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dr15Jones @cmsbuild @davidlange6