Fit CSC comparator digis #18875
Fit CSC comparator digis #18875
Conversation
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: DataFormats/CSCDigi @civanch, @mdhildreth, @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 899326e You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testRecoMETMETProducers had ERRORS |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
The error is unrelated to this PR: + cmsRun /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-22-1100/src/RecoMET/METProducers/test/recoMET_caloMet_cfg.py
22-May-2017 18:11:23 CEST Initiating request to open file file:ttbarForMetTests.root
----- Begin Fatal Exception 22-May-2017 18:11:24 CEST-----------------------
An exception of category 'FileOpenError' occurred while
[0] Constructing the EventProcessor
[1] Constructing input source of type PoolSource
[2] Calling RootFileSequenceBase::initTheFile()
[3] Calling StorageFactory::open()
[4] Calling File::sysopen()
Exception Message:
Failed to open the file 'ttbarForMetTests.root'
Additional Info:
[a] Input file file:ttbarForMetTests.root could not be opened.
[b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------
+ die 'Failure using recoMET_caloMet_cfg.py' 84
+ echo Failure using recoMET_caloMet_cfg.py: status 84
Failure using recoMET_caloMet_cfg.py: status 84
+ exit 84
status = 21504
---> test testRecoMETMETProducers had ERRORS
@civanch Could you run the tests again, please? Thank you. |
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #18875 was updated. @civanch, @mdhildreth, @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
merge |
In this pull request I introduce a class CSCComparatorDigiFitter. It fits a straight line to CSCComparatorDigis belonging to a CSCCorrelatedLCTDigi. The CSCComparatorDigis are matched to the CSCCorrelatedLCTDigi in each layer (1 through 6) by comparing CSCComparatorDigi half-strip (obtained from the strip and comparator reading) to the available halfstrip in the CSCCorrelatedLCTDigi pattern. This class is essential to build the first implementation of the L1 displaced muon trigger for the endcap. It improves the CSC stub position resolution in each station by a factor ~2.2 which is necessary for an accurate pT measurement. Ultimately, the CSCComparatorDigis will be fit in the CSCCathodeLCTProcessor class in a way that matches the firmware closely, but that is not scheduled to be done soon. Results are shown below.
ME1/b chamber:
ME2/1 chamber:
Other changes in this pull request:
There should be no changes to the Run-2 or Phase-2 scenario. This class will be used in due time when the L1 displaced muon producer is completed.
@tahuang1991