New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the dead headers ColumnPacker.hh/ColumnPackerHelper.hh #18887
Remove the dead headers ColumnPacker.hh/ColumnPackerHelper.hh #18887
Conversation
ColumnPacker.hh doesn't seem to be used and was never updated since it was imported to git. Additionally it doesn't compile because line 749 isn't even a valid C++ token sequence: static_assert((IOIsSameType<stored_type, "requested type>::value"); ColumnPackerHelper.hh is removed because it depends on ColumnPacker (even though it never includes the related header...).
Part of the work going on regarding issue #15248 |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: Alignment/Geners @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
ColumnPacker.hh doesn't seem to be used and was never updated since it
was imported to git.
Additionally it doesn't compile because line 749 isn't even a valid
C++ token sequence:
ColumnPackerHelper.hh is removed because it depends on ColumnPacker
(even though it never includes the related header...).