Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem21 services geometry #1889

Merged
merged 4 commits into from Dec 20, 2013
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Dec 19, 2013

  • Fix for GE2/1 numbering from Marcello
  • Extend coverage
  • Bugfix in GE21L positioning in negative Z

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna for CMSSW_7_0_X.

Gem21 services geometry

It involves the following packages:

Geometry/MuonCommonData
Geometry/MuonNumbering

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@ianna
Copy link
Contributor Author

ianna commented Dec 19, 2013

@dildick - the station number should be ok now.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #1889 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again.

@ktf
Copy link
Contributor

ktf commented Dec 20, 2013

@ianna you did not +1 this. Any reason for it?

@ianna
Copy link
Contributor Author

ianna commented Dec 20, 2013

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes (tests are also fine). @ktf can you please take care of it?

ktf added a commit that referenced this pull request Dec 20, 2013
Geometry updates -- Gem21 services geometry
@ktf ktf merged commit fcbfa23 into cms-sw:CMSSW_7_0_X Dec 20, 2013
@ianna ianna deleted the gem21-services-geometry branch October 26, 2015 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants