Initial push for LumiZCounting #18899

xmniu · 2017-05-23T15:01:56Z

This is the initial push for DQM LumiZCounting.
14 2D histograms are booked in order to calculate Z yields and efficiencies, for a certain time window, say a couple of lumi-sections.

cmsbuild · 2017-05-23T15:02:15Z

A new Pull Request was created by @xmniu (Xinmei Niu) for master.

It involves the following packages:

DQMOffline/LumiZCounting

The following packages do not have a category, yet:

DQMOffline/LumiZCounting
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories.py to assign category

@cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

dmitrijus · 2017-05-24T11:11:13Z

DQMOffline/LumiZCounting/BuildFile.xml

+<use name="TrackingTools/IPTools"/>
+<use name="boost"/>
+<use name="root"/>
+<flags CXXFLAGS="-g -Wall"/>


Please remove this. If you want to use "-g" or other flags locally, please use export USER_CXXFLAGS="-ggdb".
But don't put them into module scope!

dmitrijus · 2017-05-24T11:11:55Z

DQMOffline/LumiZCounting/plugins/BuildFile.xml

+<use name="DQMServices/Core"/>
+<use name="DataFormats/CLHEP"/>
+<use name="DQMOffline/LumiZCounting"/>
+<flags CXXFLAGS="-g -Wall"/>


dmitrijus · 2017-05-24T11:16:18Z

DQMOffline/LumiZCounting/data/HLTFile_phys14

@@ -0,0 +1,98 @@
+// SingleMu


Why not put these files into python configuration file?
I think it would cleaner that way (and less ways in which things can break: no file discovery, etc.)

The files in data/ and the data/ subfolder will be removed. Actually the trigger menu is not needed, since we plan to use one same trigger over entire data taking period.

dmitrijus · 2017-05-24T11:27:30Z

DQMOffline/LumiZCounting/interface/RunLumiRangeMap.h

+      typedef std::pair<unsigned int, unsigned int>                RunLumiPairType;
+      typedef std::map<unsigned int, std::vector<RunLumiPairType>> MapType;
+
+      RunLumiRangeMap(){}


Is this code used? If not, please remove it or move to "test/" subdirectory (if for some reason you want/need to preserve it).

Not for now, will remove to test/ since it might be used if we decide to do a lumi mask in the future.

dmitrijus · 2017-05-24T11:30:15Z

DQMOffline/LumiZCounting/plugins/ZCounting.cc

+//
+void ZCounting::setTriggers()
+{
+  std::string cmssw_base_src = getenv("CMSSW_BASE"); cmssw_base_src+="/src/";


This will most likely fail in any production environment. That is why it would be for the best to put those files into python configuration (PSet() and friends).

This will be removed together with data/.

dmitrijus · 2017-05-24T11:31:04Z

DQMOffline/LumiZCounting/plugins/ZCounting.h

+  edm::EDGetTokenT<reco::TrackCollection> fTrackName_token;
+
+  // bacon fillers
+  baconhep::TTrigger        *fTrigger;


Please use std::unique_ptr<baconhep::TTrigger>.

dmitrijus · 2017-05-24T11:32:20Z

please test

cmsbuild · 2017-05-24T11:32:35Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20055/console Started: 2017/05/24 13:34

dmitrijus · 2017-05-24T11:32:53Z

I have added few comments / questions. The most important issue is the use of "data/" files, I am sure they are broken :)

cmsbuild · 2017-05-24T13:08:41Z

+1
Tested at: 5bd545f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18899/20055/summary.html

cmsbuild · 2017-05-24T13:08:45Z

Comparison job queued.

cmsbuild · 2017-05-24T14:57:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18899/20055/summary.html

Comparison Summary:

You potentially added 192 lines to the logs
Reco comparison results: 3394 differences found in the comparisons
DQMHistoTests: Total files compared: 24
DQMHistoTests: Total histograms compared: 1833058
DQMHistoTests: Total failures: 34440
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1798438
DQMHistoTests: Total skipped: 180
DQMHistoTests: Total Missing objects: 0
Checked 98 log files, 14 edm output root files, 24 DQM output files

cmsbuild · 2017-05-24T16:07:00Z

Pull request #18899 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6 can you please check and sign again.

cmsbuild · 2017-05-25T10:14:07Z

Pull request #18899 was updated. @cmsbuild, @davidlange6 can you please check and sign again.

xmniu · 2017-05-31T09:37:58Z

@dmitrijus your comments have been implemented, please check again. thanks.

davidlange6 · 2017-07-07T11:58:53Z

DQMOffline/Lumi/plugins/ZCounting.cc

+{//Muon isolation selection, up-to-date with MUO POG recommendation
+
+    if(isoType == TrackerIso && muon.isolationR03().sumPt < isoCut) return true;
+    else if(isoType == PFIso && muon.pfIsolationR04().sumChargedHadronPt + TMath::Max(0.,muon.pfIsolationR04().sumNeutralHadronEt + muon.pfIsolationR04().sumPhotonEt - 0.5*muon.pfIsolationR04().sumPUPt) < isoCut) return true;


hi @xmniu - sorry missed this - TMath::Max can just be std::max (then you can remove all the TMath.h includes

davidlange6 · 2017-07-07T12:02:35Z

DQMOffline/Lumi/plugins/ZCounting.cc

+
+      // Mass window
+      TLorentzVector vDilep = vTag + vProbe;
+      if((vDilep.M() < MassMin_) || (vDilep.M() > MassMax_)) continue;


please make a variable for vDilep.M() to avoid redundant calculations- you use it many times.

davidlange6 · 2017-07-07T12:04:08Z

DQMOffline/Lumi/interface/TriggerRecord.h

+class TriggerRecord
+{
+public:
+  TriggerRecord(const std::string name="", const unsigned int value=0) {


one more const std::string &

davidlange6 · 2017-07-07T12:04:58Z

otherwise looks ready to me

…ng to new HLT menu of 2017B

cmsbuild · 2017-07-07T13:42:11Z

Pull request #18899 was updated. @vazzolini, @dmitrijus, @kmaeshima, @kpedro88, @fabozzi, @cmsbuild, @kkousour, @GurpreetSinghChahal, @vanbesien, @davidlange6 can you please check and sign again.

davidlange6 · 2017-07-07T13:49:07Z

please test

cmsbuild · 2017-07-07T13:49:55Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21261/console Started: 2017/07/07 18:56

cmsbuild · 2017-07-07T19:51:23Z

+1
Tested at: f79b783
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18899/21261/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
7c04e1c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18899/21261/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18899/21261/git-merge-result

cmsbuild · 2017-07-07T19:51:26Z

Comparison job queued.

cmsbuild · 2017-07-08T00:47:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18899/21261/summary.html

Comparison Summary:

You potentially added 5 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1790682
DQMHistoTests: Total failures: 29469
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1761047
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

davidlange6 · 2017-07-09T05:37:58Z

merge

cmsbuild added this to the CMSSW_9_2_X milestone May 23, 2017

cmsbuild added comparison-pending new-package-pending orp-pending pending-signatures tests-pending labels May 23, 2017

dmitrijus suggested changes May 24, 2017

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels May 24, 2017

cmsbuild added tests-approved and removed tests-started labels May 24, 2017

cmsbuild added comparison-available alca-pending comparison-pending tests-pending and removed comparison-pending comparison-available tests-approved labels May 24, 2017

xmniu force-pushed the init-for-lumizcounting branch from 112354c to 30822b0 Compare May 25, 2017 10:13

cmsbuild removed the alca-pending label May 25, 2017

davidlange6 reviewed Jul 7, 2017

View reviewed changes

xmniu added 11 commits July 7, 2017 15:23

get rid of the intermediate TTree

2ec5bfd

updates according to comments from dmitrijus, May 24th

bf22a43

rename package to DQMOffline/Lumi, rename namespace, use unique_ptr

a683c7c

add ZCounting_cff.py for Z Counting module

30926b6

Create autoDQM.py

1d38948

add lumi zcounting module

d6b6244

remove process. to fix the bug in tests

b824c8b

implemented comments from David and Dmitrijus, update trigger accordi…

e32f254

…ng to new HLT menu of 2017B

add lumi module to matrix workflow

ab578ec

implemented comments from from David and updated LS bin and muon trigger

27f5315

implemented comments from David, July 7th

f79b783

xmniu force-pushed the init-for-lumizcounting branch from 7193475 to f79b783 Compare July 7, 2017 13:41

cmsbuild added tests-started and removed tests-pending labels Jul 7, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 7, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 8, 2017

cmsbuild merged commit 0619998 into cms-sw:master Jul 9, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial push for LumiZCounting #18899

Initial push for LumiZCounting #18899

xmniu commented May 23, 2017

cmsbuild commented May 23, 2017

dmitrijus May 24, 2017

xmniu May 24, 2017

dmitrijus May 24, 2017

xmniu May 24, 2017

dmitrijus May 24, 2017

xmniu May 24, 2017

dmitrijus May 24, 2017

xmniu May 24, 2017

dmitrijus May 24, 2017

xmniu May 24, 2017

dmitrijus May 24, 2017

dmitrijus commented May 24, 2017

cmsbuild commented May 24, 2017 •

edited

dmitrijus commented May 24, 2017

cmsbuild commented May 24, 2017

cmsbuild commented May 24, 2017

cmsbuild commented May 24, 2017

cmsbuild commented May 24, 2017

cmsbuild commented May 25, 2017

xmniu commented May 31, 2017

davidlange6 Jul 7, 2017

davidlange6 Jul 7, 2017

davidlange6 Jul 7, 2017

davidlange6 commented Jul 7, 2017

cmsbuild commented Jul 7, 2017

davidlange6 commented Jul 7, 2017

cmsbuild commented Jul 7, 2017 •

edited

cmsbuild commented Jul 7, 2017

cmsbuild commented Jul 7, 2017

cmsbuild commented Jul 8, 2017

davidlange6 commented Jul 9, 2017

Initial push for LumiZCounting #18899

Initial push for LumiZCounting #18899

Conversation

xmniu commented May 23, 2017

cmsbuild commented May 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmitrijus commented May 24, 2017

cmsbuild commented May 24, 2017 • edited

dmitrijus commented May 24, 2017

cmsbuild commented May 24, 2017

cmsbuild commented May 24, 2017

cmsbuild commented May 24, 2017

cmsbuild commented May 24, 2017

cmsbuild commented May 25, 2017

xmniu commented May 31, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidlange6 commented Jul 7, 2017

cmsbuild commented Jul 7, 2017

davidlange6 commented Jul 7, 2017

cmsbuild commented Jul 7, 2017 • edited

cmsbuild commented Jul 7, 2017

cmsbuild commented Jul 7, 2017

cmsbuild commented Jul 8, 2017

davidlange6 commented Jul 9, 2017

cmsbuild commented May 24, 2017 •

edited

cmsbuild commented Jul 7, 2017 •

edited