[92X] Apply surface parameters only if selected for alignment.

[ghellwig]

Mainly a cosmetic fix to ensure that flat modules stay flat when the surfaces are not included in the alignment fit.
Only cosmetic because the created payload is normally not used, but in case someone accidentally loads both alignment and surfaces from the output file, the correct behaviour is ensured now also for ideal surfaces.

[ghellwig]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20048/console Started: 2017/05/23 20:26

[cmsbuild]

A new Pull Request was created by @ghellwig (Gregor Mittag) for master.

It involves the following packages:

Alignment/CommonAlignmentParametrization

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @tocheng, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 197d7e0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18904/20048/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
fdf66db
abca4a4
fccdc70
564df1a
c1ebfd3
664f680
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18904/20048/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18904/20048/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18904/20048/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 1687 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1832990
• DQMHistoTests: Total failures: 56662
• DQMHistoTests: Total nulls: 66
• DQMHistoTests: Total successes: 1776082
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[ghellwig]

ping

[ghellwig]

ping @franzoni @arunhep

[arunhep]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20345/console Started: 2017/06/06 13:12

[cmsbuild]

+1
Tested at: 197d7e0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18904/20345/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18904/20345/summary.html

Comparison Summary:

• You potentially added 192 lines to the logs
• Reco comparison results: 3413 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1837639
• DQMHistoTests: Total failures: 19285
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1818181
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[arunhep]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1

[ghellwig]

thanks @arunhep!