SimCalorimetry : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18926

gartung · 2017-05-24T23:45:33Z

Fixes warnings like these by adding virtual destructor with default constructor.

/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/d36af6c2d5d322e52932978c6b2c4857/opt/cmssw/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_9_2_X_2017-05-23-2300/src/SimCalorimetry/HGCalSimProducers/interface/HGCDigitizerBase.h:25:7: warning: 'class HGCDigitizerBase<HGCDataFrame<HGCalDetId, HGCSample> >' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]

/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/d36af6c2d5d322e52932978c6b2c4857/opt/cmssw/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_9_2_X_2017-05-23-2300/src/SimCalorimetry/HGCalSimProducers/interface/HGCEEDigitizer.h:7:7: warning: base class 'class HGCDigitizerBase<HGCDataFrame<HGCalDetId, HGCSample> >' has accessible non-virtual destructor [-Wnon-virtual-dtor]

/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/d36af6c2d5d322e52932978c6b2c4857/opt/cmssw/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_9_2_X_2017-05-23-2300/src/SimCalorimetry/HGCalSimProducers/interface/HGCHEbackDigitizer.h:7:7: warning: base class 'class HGCDigitizerBase<HGCDataFrame<HcalDetId, HGCSample> >' has accessible non-virtual destructor [-Wnon-virtual-dtor]

…rtual destructor [-Wnon-virtual-dtor]

cmsbuild · 2017-05-24T23:45:51Z

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

SimCalorimetry/CaloSimAlgos
SimCalorimetry/HGCalSimProducers
SimCalorimetry/HcalZeroSuppressionProducers

@cmsbuild, @civanch, @mdhildreth, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @kpedro88, @lgray, @cseez, @pfs this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2017-05-25T00:07:45Z

please test

cmsbuild · 2017-05-25T00:08:04Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20083/console Started: 2017/05/25 02:10

gartung · 2017-05-25T00:10:40Z

@kpedro88 hold on. I need to fix some errors.

kpedro88 · 2017-05-25T00:11:13Z

please abort

cmsbuild · 2017-05-25T00:11:36Z

Jenkins tests are aborted.

gartung · 2017-05-25T00:12:02Z

@kpedro88 sorry this one is ready. I am working on the SimTracker pull.

kpedro88 · 2017-05-25T00:20:27Z

please test

cmsbuild · 2017-05-25T00:20:51Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20084/console Started: 2017/05/25 02:21

cmsbuild · 2017-05-25T02:30:12Z

-1

Tested at: 7e7c165

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
09f887d
1cb2dec
14591b1
c58ba64
6b37f47
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18926/20084/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18926/20084/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18926/20084/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:Full2015Data --data --scenario=HeavyIons -n 10 --conditions auto:run2_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/hidata/HIRun2015/HIHardProbes/RAW-RECO/HighPtJet-PromptReco-v1/000/263/689/00000/1802CD9A-DDB8-E511-9CF9-02163E0138CA.root : FAILED - time: date Thu May 25 04:10:48 2017-date Thu May 25 04:06:01 2017 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02473/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-05-24-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu May 25 04:10:48 2017-date Thu May 25 04:06:01 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Thu May 25 04:10:48 2017-date Thu May 25 04:06:01 2017 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PIon --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --magField 38T_PostLS1 --eventcontent RAW --fileout file:RelVal_Raw_PIon_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Thu May 25 04:19:01 2017-date Thu May 25 04:10:51 2017 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02473/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-05-24-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu May 25 04:19:01 2017-date Thu May 25 04:10:51 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Thu May 25 04:19:01 2017-date Thu May 25 04:10:51 2017 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Thu May 25 04:20:47 2017-date Thu May 25 04:16:44 2017 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02473/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-05-24-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu May 25 04:20:47 2017-date Thu May 25 04:16:44 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Thu May 25 04:20:47 2017-date Thu May 25 04:16:44 2017 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_GRun2016 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun2016_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Thu May 25 04:22:58 2017-date Thu May 25 04:18:30 2017 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02473/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-05-24-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun2016.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu May 25 04:22:58 2017-date Thu May 25 04:18:30 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun2016,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun2016 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun2016_DATA.root --fileout file:RelVal_Raw_GRun2016_DATA_HLT_RECO.root : FAILED - time: date Thu May 25 04:22:58 2017-date Thu May 25 04:18:30 2017 s - exit: 21504

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
09f887d
1cb2dec
14591b1
c58ba64
6b37f47
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18926/20084/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18926/20084/git-merge-result

cmsbuild · 2017-05-25T02:30:15Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

gartung · 2017-05-25T15:35:40Z

@Dr15Jones retest please

cmsbuild · 2017-05-25T15:49:09Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20110/console Started: 2017/05/25 18:05

gartung · 2017-05-25T16:09:55Z

@Dr15Jones I don't understand what failed here.

Dr15Jones · 2017-05-25T16:21:44Z

I think it was a transient build glitch. That is why I restarted the test.

cmsbuild · 2017-05-25T17:50:10Z

+1
Tested at: 7e7c165
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18926/20110/summary.html

cmsbuild · 2017-05-25T17:50:13Z

Comparison job queued.

cmsbuild · 2017-05-25T21:13:13Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18926/20110/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 1694 differences found in the comparisons
DQMHistoTests: Total files compared: 24
DQMHistoTests: Total histograms compared: 1833592
DQMHistoTests: Total failures: 39122
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1794290
DQMHistoTests: Total skipped: 180
DQMHistoTests: Total Missing objects: 0
Checked 98 log files, 14 edm output root files, 24 DQM output files

civanch · 2017-05-26T09:39:34Z

+1

kpedro88 · 2017-05-26T15:54:33Z

+1

cmsbuild · 2017-05-26T15:54:52Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-05-27T07:44:01Z

+1

fix gcc700 warning: class has virtual functions and accessible non-vi…

7e7c165

…rtual destructor [-Wnon-virtual-dtor]

cmsbuild added this to the CMSSW_9_2_X milestone May 24, 2017

cmsbuild added comparison-pending orp-pending pending-signatures simulation-pending tests-pending upgrade-pending labels May 24, 2017

cmsbuild added tests-started and removed tests-pending labels May 25, 2017

cmsbuild added tests-pending and removed tests-started labels May 25, 2017

cmsbuild added tests-started and removed tests-pending labels May 25, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels May 25, 2017

cmsbuild removed comparison-notrun tests-rejected labels May 25, 2017

cmsbuild added comparison-pending tests-pending tests-started and removed tests-pending labels May 25, 2017

cmsbuild added tests-approved and removed tests-started labels May 25, 2017

cmsbuild added comparison-available and removed comparison-pending labels May 25, 2017

cmsbuild added simulation-approved and removed simulation-pending labels May 26, 2017

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels May 26, 2017

cmsbuild added orp-approved and removed orp-pending labels May 27, 2017

cmsbuild merged commit 82967c7 into cms-sw:master May 27, 2017

gartung deleted the SimCalo-gcc700-dtor-warning-fix branch May 30, 2017 15:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SimCalorimetry : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18926

SimCalorimetry : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18926

gartung commented May 24, 2017

cmsbuild commented May 24, 2017

kpedro88 commented May 25, 2017

cmsbuild commented May 25, 2017 •

edited

gartung commented May 25, 2017

kpedro88 commented May 25, 2017

cmsbuild commented May 25, 2017

gartung commented May 25, 2017

kpedro88 commented May 25, 2017

cmsbuild commented May 25, 2017 •

edited

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

gartung commented May 25, 2017

cmsbuild commented May 25, 2017 •

edited

gartung commented May 25, 2017

Dr15Jones commented May 25, 2017

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

civanch commented May 26, 2017

kpedro88 commented May 26, 2017

cmsbuild commented May 26, 2017

davidlange6 commented May 27, 2017

SimCalorimetry : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18926

SimCalorimetry : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18926

Conversation

gartung commented May 24, 2017

cmsbuild commented May 24, 2017

kpedro88 commented May 25, 2017

cmsbuild commented May 25, 2017 • edited

gartung commented May 25, 2017

kpedro88 commented May 25, 2017

cmsbuild commented May 25, 2017

gartung commented May 25, 2017

kpedro88 commented May 25, 2017

cmsbuild commented May 25, 2017 • edited

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

gartung commented May 25, 2017

cmsbuild commented May 25, 2017 • edited

gartung commented May 25, 2017

Dr15Jones commented May 25, 2017

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

civanch commented May 26, 2017

kpedro88 commented May 26, 2017

cmsbuild commented May 26, 2017

davidlange6 commented May 27, 2017

cmsbuild commented May 25, 2017 •

edited

cmsbuild commented May 25, 2017 •

edited

cmsbuild commented May 25, 2017 •

edited