Alignment : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18933

gartung · 2017-05-25T14:36:05Z

Fixes warnings like these by adding virtual destructor with default constructor.

/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8fa3f79dab694f86b12f10b4e4cceb97/opt/cmssw/slc6_amd64_gcc700/cms/cmssw/CMSSW_9_2_X_2017-05-21-2300/src/Alignment/CommonAlignmentAlgorithm/interface/AlignmentIO.h:19:7: warning: 'class AlignmentIO' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]

/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8fa3f79dab694f86b12f10b4e4cceb97/opt/cmssw/slc6_amd64_gcc700/cms/cmssw/CMSSW_9_2_X_2017-05-21-2300/src/Alignment/CommonAlignmentAlgorithm/interface/AlignmentIORoot.h:16:7: warning: base class 'class AlignmentIO' has accessible non-virtual destructor [-Wnon-virtual-dtor]

cmsbuild · 2017-05-25T14:36:26Z

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

Alignment/CommonAlignmentAlgorithm

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @tocheng, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

gartung · 2017-05-25T15:36:00Z

@Dr15Jones

Dr15Jones · 2017-05-25T15:36:27Z

please test

cmsbuild · 2017-05-25T15:36:41Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20098/console Started: 2017/05/25 17:37

cmsbuild · 2017-05-25T15:44:47Z

-1

Tested at: 715b56c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18933/20098/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-24-2300/src/Alignment/CommonAlignmentAlgorithm/src/AlignableDataIO.cc 
Entering library rule at src/Alignment/MillePedeAlignmentAlgorithm/plugins
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-24-2300/src/Alignment/CommonAlignmentAlgorithm/plugins/SiPixelLorentzAngleCalibration.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-24-2300/src/Alignment/CommonAlignmentAlgorithm/plugins/ApeSettingAlgorithm.cc 
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-24-2300/src/Alignment/CommonAlignmentAlgorithm/src/AlignmentIORoot.cc:6:0:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-24-2300/src/Alignment/CommonAlignmentAlgorithm/interface/AlignmentIORoot.h:20:26: error: expected class-name before '(' token
   virtual ~AlignmentIORoo() = default;
                          ^
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-24-2300/src/Alignment/CommonAlignmentAlgorithm/plugins/SiStripLorentzAngleCalibration.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-24-2300/src/Alignment/CommonAlignmentAlgorithm/plugins/SiStripBackplaneCalibration.cc 
gmake: *** [tmp/slc6_amd64_gcc530/src/Alignment/CommonAlignmentAlgorithm/src/AlignmentCommonAlignmentAlgorithm/AlignmentIORoot.o] Error 1

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-24-2300/src/Alignment/CommonAlignmentAlgorithm/src/AlignmentIORoot.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-24-2300/src/Alignment/CommonAlignmentAlgorithm/src/IntegratedCalibrationBase.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-24-2300/src/Alignment/CommonAlignmentAlgorithm/src/AlignmentAlgorithmPluginFactory.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-24-2300/src/Alignment/CommonAlignmentAlgorithm/src/AlignableDataIO.cc 
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-24-2300/src/Alignment/CommonAlignmentAlgorithm/src/AlignmentIORoot.cc:6:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-24-2300/src/Alignment/CommonAlignmentAlgorithm/interface/AlignmentIORoot.h:20:12: error: expected the class name after '~' to name a destructor
  virtual ~AlignmentIORoo() = default;
           ^~~~~~~~~~~~~~
           AlignmentIORoot
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-24-2300/src/Alignment/CommonAlignmentAlgorithm/plugins/SiPixelLorentzAngleCalibration.cc 
1 error generated.

cmsbuild · 2017-05-25T15:44:49Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

…rtual destructor [-Wnon-virtual-dtor]

cmsbuild · 2017-05-25T16:06:17Z

Pull request #18933 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6 can you please check and sign again.

Dr15Jones · 2017-05-25T16:07:28Z

please test

cmsbuild · 2017-05-25T16:07:47Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20112/console Started: 2017/05/25 18:17

cmsbuild · 2017-05-25T17:02:36Z

+1
Tested at: 8ba75ea
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18933/20112/summary.html

cmsbuild · 2017-05-25T17:02:39Z

Comparison job queued.

cmsbuild · 2017-05-25T19:57:15Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18933/20112/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 1706 differences found in the comparisons
DQMHistoTests: Total files compared: 24
DQMHistoTests: Total histograms compared: 1833558
DQMHistoTests: Total failures: 42762
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1790616
DQMHistoTests: Total skipped: 180
DQMHistoTests: Total Missing objects: 0
Checked 98 log files, 14 edm output root files, 24 DQM output files

arunhep · 2017-05-29T20:40:21Z

+1
no change in plots as expected. technical update only.

cmsbuild · 2017-05-29T20:40:37Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-05-30T07:42:56Z

+1

cmsbuild added this to the CMSSW_9_2_X milestone May 25, 2017

cmsbuild added alca-pending comparison-pending orp-pending pending-signatures tests-pending labels May 25, 2017

cmsbuild added tests-started and removed tests-pending labels May 25, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels May 25, 2017

fix gcc700 warning: class has virtual functions and accessible non-vi…

8ba75ea

…rtual destructor [-Wnon-virtual-dtor]

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels May 25, 2017

cmsbuild added tests-started and removed tests-pending labels May 25, 2017

cmsbuild added tests-approved and removed tests-started labels May 25, 2017

cmsbuild added comparison-available and removed comparison-pending labels May 25, 2017

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels May 29, 2017

cmsbuild added orp-approved and removed orp-pending labels May 30, 2017

cmsbuild merged commit 12a8208 into cms-sw:master May 30, 2017

gartung deleted the Align-gcc700-dtor-warning-fix branch May 30, 2017 15:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alignment : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18933

Alignment : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18933

gartung commented May 25, 2017

cmsbuild commented May 25, 2017

gartung commented May 25, 2017

Dr15Jones commented May 25, 2017

cmsbuild commented May 25, 2017 •

edited

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

Dr15Jones commented May 25, 2017

cmsbuild commented May 25, 2017 •

edited

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

arunhep commented May 29, 2017

cmsbuild commented May 29, 2017

davidlange6 commented May 30, 2017

Alignment : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18933

Alignment : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18933

Conversation

gartung commented May 25, 2017

cmsbuild commented May 25, 2017

gartung commented May 25, 2017

Dr15Jones commented May 25, 2017

cmsbuild commented May 25, 2017 • edited

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

Dr15Jones commented May 25, 2017

cmsbuild commented May 25, 2017 • edited

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

arunhep commented May 29, 2017

cmsbuild commented May 29, 2017

davidlange6 commented May 30, 2017

cmsbuild commented May 25, 2017 •

edited

cmsbuild commented May 25, 2017 •

edited