Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventFilter : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18938

Merged
merged 1 commit into from May 30, 2017
Merged

EventFilter : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion EventFilter/L1TRawToDigi/interface/Block.h
View file
Open in desktop
Expand Up @@ -74,7 +74,7 @@ namespace l1t {
class Payload {
public:
Payload(const uint32_t * data, const uint32_t * end) : data_(data), end_(end), algo_(0), infra_(0) {};

virtual ~Payload() {};
virtual unsigned getAlgorithmFWVersion() const { return algo_; };
virtual unsigned getInfrastructureFWVersion() const { return infra_; };
virtual unsigned getHeaderSize() const = 0;
Expand Down
1 change: 1 addition & 0 deletions EventFilter/L1TRawToDigi/interface/PackingSetup.h
View file
Open in desktop
Expand Up @@ -29,6 +29,7 @@ namespace l1t {
class PackingSetup {
public:
PackingSetup() {};
virtual ~PackingSetup() {};
virtual std::unique_ptr<PackerTokens> registerConsumes(const edm::ParameterSet&, edm::ConsumesCollector&) = 0;
virtual void registerProducts(edm::stream::EDProducerBase&) = 0;

Expand Down
1 change: 1 addition & 0 deletions EventFilter/L1TRawToDigi/plugins/implementations_stage1/CaloSetup.h
View file
Open in desktop
Expand Up @@ -13,6 +13,7 @@ namespace l1t {
namespace stage1 {
class CaloSetup : public PackingSetup {
public:
virtual ~CaloSetup() {};
virtual std::unique_ptr<PackerTokens> registerConsumes(const edm::ParameterSet& cfg, edm::ConsumesCollector& cc) override;
virtual void fillDescription(edm::ParameterSetDescription& desc) override;
virtual PackerMap getPackers(int fed, unsigned int fw) override;
Expand Down
1 change: 1 addition & 0 deletions EventFilter/L1TRawToDigi/plugins/implementations_stage2/GTSetup.h
View file
Open in desktop
Expand Up @@ -13,6 +13,7 @@ namespace l1t {
namespace stage2 {
class GTSetup : public PackingSetup {
public:
virtual ~GTSetup() {};
virtual std::unique_ptr<PackerTokens> registerConsumes(const edm::ParameterSet& cfg, edm::ConsumesCollector& cc) override;
virtual void fillDescription(edm::ParameterSetDescription& desc) override;
virtual PackerMap getPackers(int fed, unsigned int fw) override;
Expand Down