Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang update EDMPluginDumper and FunctionDumper #1894

Merged
merged 2 commits into from Dec 19, 2013
Merged

Clang update EDMPluginDumper and FunctionDumper #1894

merged 2 commits into from Dec 19, 2013

Conversation

gartung
Copy link
Member

@gartung gartung commented Dec 19, 2013

EDMPluginDumper now output template argument when the plugin is a template class.

FunctionDumper now logs cxx constructor calls. This is needed so that top level functions can be linked to constructor calls the access statics, eg gen::FortranInstance::InstanceWrapper

@gartung
update EDMPluginDumper to output the template args
e6d82ac 
if the plugin class is a template specialization
Also remove checking the log contents before writing to log as this
causes the FunctionDumper to take too long trying to load the large
log file for each process and each function call.
@gartung
log constructor calls
ef6cd84
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X.

Clang update EDMPluginDumper and FunctionDumper

It involves the following packages:

Utilities/StaticAnalyzers

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1894/1871/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes (tests are also fine). @ktf can you please take care of it?

ktf added a commit that referenced this pull request Dec 19, 2013
@ktf
Merge pull request #1894 from gartung/clang-update-edmplugin-dumper
08670de 
Tools updates -- Clang update EDMPluginDumper and FunctionDumper
@ktf ktf merged commit 08670de into cms-sw:CMSSW_7_0_X Dec 19, 2013
@gartung gartung deleted the clang-update-edmplugin-dumper branch December 19, 2013 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_0_0_pre11
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gartung @cmsbuild @Dr15Jones @ktf