L1Trigger : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18941
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: L1Trigger/L1TMuonBarrel @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| @@ -37,7 +37,7 @@ class L1ITMuonBarrelPrimitiveProducer { | |||
|
|
|||
| public: | |||
| inline L1ITMuonBarrelPrimitiveProducer(std::unique_ptr<MBLTContainer> _mbltContainer); | |||
| inline ~L1ITMuonBarrelPrimitiveProducer(); | |||
| inline virtual ~L1ITMuonBarrelPrimitiveProducer() = default; | |||
There was a problem hiding this comment.
Since this was declared already, it means there must be a definition that exists. Please change this to
inline virtual ~L1ITMuonBarrelPrimitiveProducer();.
…rtual destructor [-Wnon-virtual-dtor]
|
Pull request #18941 was updated. @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 |
Fixes warnings like these by adding virtual destructor with default constructor.
/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8fa3f79dab694f86b12f10b4e4cceb97/opt/cmssw/slc6_amd64_gcc700/cms/cmssw/CMSSW_9_2_X_2017-05-21-2300/src/L1Trigger/RPCTrigger/interface/RPCTriggerConfiguration.h:13:7: warning: 'class RPCTriggerConfiguration' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8fa3f79dab694f86b12f10b4e4cceb97/opt/cmssw/slc6_amd64_gcc700/cms/cmssw/CMSSW_9_2_X_2017-05-21-2300/src/L1Trigger/RPCTrigger/interface/RPCBasicTrigConfig.h:14:7: warning: base class 'class RPCTriggerConfiguration' has accessible non-virtual destructor [-Wnon-virtual-dtor]