Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecoBTag : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18943

Merged
merged 1 commit into from May 27, 2017
Merged

Conversation

gartung
Copy link
Member

@gartung gartung commented May 25, 2017

Fixes warnings like these by adding virtual destructor with default constructor.

/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8fa3f79dab694f86b12f10b4e4cceb97/opt/cmssw/slc6_amd64_gcc700/cms/cmssw/CMSSW_9_2_X_2017-05-21-2300/src/RecoBTag/XMLCalibration/interface/CalibratedObject.h:14:7: warning: 'class CalibratedObject' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]

/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8fa3f79dab694f86b12f10b4e4cceb97/opt/cmssw/slc6_amd64_gcc700/cms/cmssw/CMSSW_9_2_X_2017-05-21-2300/src/RecoBTag/SecondaryVertex/interface/GhostTrackComputer.h:16:7: warning: 'class GhostTrackComputer' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

RecoBTag/SecondaryVertex
RecoBTag/XMLCalibration

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@imarches, @acaudron, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented May 25, 2017

@Dr15Jones

@slava77
Copy link
Contributor

slava77 commented May 25, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 25, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20102/console Started: 2017/05/25 17:45

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18943/20102/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1694 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833592
  • DQMHistoTests: Total failures: 53587
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1779825
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@perrotta
Copy link
Contributor

+1

  • technical fix,
  • jenkins tests pass
  • if c++ gurus endorse it, it is also fine for reco

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3103b54 into cms-sw:master May 27, 2017
@gartung gartung deleted the RecoBTag-gcc700-dtor-warning-fix branch May 30, 2017 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants