RecoTracker: fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18947

gartung · 2017-05-25T15:30:22Z

Fixes warnings like these by adding virtual destructor with default constructor.

/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8fa3f79dab694f86b12f10b4e4cceb97/opt/cmssw/slc6_amd64_gcc700/cms/cmssw/CMSSW_9_2_X_2017-05-21-2300/src/RecoTracker/SiTrackerMRHTools/interface/MultiRecHitCollector.h:10:7: warning: 'class MultiRecHitCollector' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]

cmsbuild · 2017-05-25T15:30:40Z

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

RecoTracker/SiTrackerMRHTools
RecoTracker/TkMSParametrization

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

gartung · 2017-05-25T15:41:52Z

@Dr15Jones

slava77 · 2017-05-25T15:42:22Z

@cmsbuild please test

cmsbuild · 2017-05-25T15:43:08Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20108/console Started: 2017/05/25 17:59

cmsbuild · 2017-05-25T16:04:08Z

-1

Tested at: ad67f7e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18947/20108/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/RecoTracker/SiTrackerMRHTools/plugins/MultiRecHitCollectorESProducer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/RecoTracker/SiTrackerMRHTools/plugins/SiTrackerMultiRecHitUpdatorESProducer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/RecoTracker/TkMSParametrization/test/TestMS.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/RecoTracker/TkMSParametrization/src/MultipleScatteringX0Data.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/RecoTracker/TkMSParametrization/src/PixelRecoUtilities.cc 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/RecoTracker/TkMSParametrization/src/MultipleScatteringX0Data.cc:32:1: error: definition of explicitly-defaulted 'MultipleScatteringX0Data::~MultipleScatteringX0Data()'
 MultipleScatteringX0Data::~MultipleScatteringX0Data()
 ^
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/RecoTracker/TkMSParametrization/src/MultipleScatteringX0Data.cc:1:0:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/RecoTracker/TkMSParametrization/src/MultipleScatteringX0Data.h:23:11: error: 'virtual MultipleScatteringX0Data::~MultipleScatteringX0Data()' explicitly defaulted here
   virtual ~MultipleScatteringX0Data() = default;

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/RecoTracker/TkMSParametrization/src/MSLayer.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/RecoTracker/TkMSParametrization/src/MSLayersKeeperX0DetLayer.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/RecoTracker/TkMSParametrization/src/MSLayersAtAngle.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/RecoTracker/TkMSParametrization/src/MultipleScatteringParametrisation.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/RecoTracker/TkMSParametrization/src/MSLayersKeeperX0Averaged.cc 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/RecoTracker/TkMSParametrization/src/MultipleScatteringX0Data.cc:32:27: error: definition of explicitly defaulted destructor
MultipleScatteringX0Data::~MultipleScatteringX0Data()
                          ^
1 error generated.
gmake: *** [tmp/slc6_amd64_gcc530/src/RecoTracker/TkMSParametrization/src/RecoTrackerTkMSParametrization/MultipleScatteringX0Data.o] Error 1
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/RecoTracker/SiTrackerMRHTools/plugins/module.cc

cmsbuild · 2017-05-25T16:04:11Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

slava77 · 2017-05-25T16:06:06Z

-1

…rtual destructor [-Wnon-virtual-dtor]

cmsbuild · 2017-05-25T16:23:34Z

Pull request #18947 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

Dr15Jones · 2017-05-25T16:27:05Z

please test

cmsbuild · 2017-05-25T16:27:19Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20115/console Started: 2017/05/25 18:37

cmsbuild · 2017-05-25T17:21:03Z

+1
Tested at: a4c1037
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18947/20115/summary.html

cmsbuild · 2017-05-25T17:21:07Z

Comparison job queued.

cmsbuild · 2017-05-25T19:12:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18947/20115/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 1694 differences found in the comparisons
DQMHistoTests: Total files compared: 24
DQMHistoTests: Total histograms compared: 1833626
DQMHistoTests: Total failures: 38740
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1794706
DQMHistoTests: Total skipped: 180
DQMHistoTests: Total Missing objects: 0
Checked 98 log files, 14 edm output root files, 24 DQM output files

perrotta · 2017-05-26T13:31:05Z

+1

technical fix,
jenkins tests pass
if c++ gurus endorse it, it is also fine for reco

cmsbuild · 2017-05-26T13:32:01Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-05-27T07:41:03Z

+1

cmsbuild added this to the CMSSW_9_2_X milestone May 25, 2017

cmsbuild added comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels May 25, 2017

gartung changed the title ~~fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]~~ RecoTracker: fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] May 25, 2017

cmsbuild added tests-started and removed tests-pending labels May 25, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels May 25, 2017

cmsbuild added reconstruction-rejected and removed reconstruction-pending labels May 25, 2017

fix gcc700 warning: class has virtual functions and accessible non-vi…

a4c1037

…rtual destructor [-Wnon-virtual-dtor]

cmsbuild added comparison-pending reconstruction-pending tests-pending and removed comparison-notrun reconstruction-rejected tests-rejected labels May 25, 2017

cmsbuild added tests-started and removed tests-pending labels May 25, 2017

cmsbuild added tests-approved and removed tests-started labels May 25, 2017

cmsbuild added comparison-available and removed comparison-pending labels May 25, 2017

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels May 26, 2017

cmsbuild added orp-approved and removed orp-pending labels May 27, 2017

cmsbuild merged commit 036e79e into cms-sw:master May 27, 2017

gartung deleted the RecoTracker-gcc700-dtor-warning-fix branch May 30, 2017 15:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RecoTracker: fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18947

RecoTracker: fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18947

gartung commented May 25, 2017

cmsbuild commented May 25, 2017

gartung commented May 25, 2017

slava77 commented May 25, 2017

cmsbuild commented May 25, 2017 •

edited

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

slava77 commented May 25, 2017

cmsbuild commented May 25, 2017

Dr15Jones commented May 25, 2017

cmsbuild commented May 25, 2017 •

edited

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

perrotta commented May 26, 2017

cmsbuild commented May 26, 2017

davidlange6 commented May 27, 2017

RecoTracker: fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18947

RecoTracker: fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18947

Conversation

gartung commented May 25, 2017

cmsbuild commented May 25, 2017

gartung commented May 25, 2017

slava77 commented May 25, 2017

cmsbuild commented May 25, 2017 • edited

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

slava77 commented May 25, 2017

cmsbuild commented May 25, 2017

Dr15Jones commented May 25, 2017

cmsbuild commented May 25, 2017 • edited

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

cmsbuild commented May 25, 2017

perrotta commented May 26, 2017

cmsbuild commented May 26, 2017

davidlange6 commented May 27, 2017

cmsbuild commented May 25, 2017 •

edited

cmsbuild commented May 25, 2017 •

edited