MuonHLT IterL3 reconstruction: bug fix to avoid running twice on the same L1 #18957

folguera · 2017-05-26T08:44:54Z

This prevents to run twice on an already used L1, performance is not affected, but timing would be significantly reduced. This bug was introduced by PR #18830. Do we need a back port to 91X?

cmsbuild · 2017-05-26T08:45:16Z

A new Pull Request was created by @folguera (Santiago Folgueras) for master.

It involves the following packages:

HLTrigger/Muon

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @Martin-Grunewald, @calderona, @HuguesBrun, @trocino this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

fwyzard · 2017-05-26T08:52:26Z

@cmsbuild please test

cmsbuild · 2017-05-26T08:52:42Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20130/console Started: 2017/05/26 10:54

fwyzard · 2017-05-26T08:53:03Z

thanks Santiago, there is no need for a 91x backport

cmsbuild · 2017-05-26T09:38:36Z

+1
Tested at: fa43be2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18957/20130/summary.html

cmsbuild · 2017-05-26T09:38:39Z

Comparison job queued.

folguera · 2017-05-26T10:54:29Z

HLTrigger/Muon/src/HLTL1MuonNoL2Selector.cc

@@ -53,7 +53,6 @@ HLTL1MuonNoL2Selector::fillDescriptions(edm::ConfigurationDescriptions& descript
  edm::ParameterSetDescription desc;
  desc.add<edm::InputTag>("InputObjects",edm::InputTag(""));
  desc.add<edm::InputTag>("L2CandTag",edm::InputTag("hltL2MuonCandidates"));
-  desc.add<edm::InputTag>("L1CandTag",edm::InputTag(""));


We've removed this because it is not used anywhere in the code, but the removal of this line require parsing the code to ConfDB as the ConfDB version is still asking for this parameter. How do we want to proceed?

What do you mean? The jenkins PR tests pass, so the module is not yet used.
So the PR can get integrated, and we can parse it into ConfDB later.

fwyzard · 2017-05-26T11:04:57Z

Options:

write a customisation function in HLTrigger/Configuration/python/customizeHLTforCMSSW.py
change it to

  // # OBSOLETE - these parameters are ignored, they are left only not to break old configurations
  // they will not be printed in the generated cfi.py file
  desc.addOptionalNode(edm::ParameterDescription<edm::InputTag>("L1CandTag", "",  false), false)->setComment("This parameter is obsolete and will be ignored.");

wait for STORM to parse this PR in ConfDB

@Martin-Grunewald @silviodonato what do you prefer ?

Martin-Grunewald · 2017-05-26T11:06:45Z

2 or 3 would be fine, 1 is a bit overkill.... as the module is not yet used.

cmsbuild · 2017-05-26T11:06:53Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18957/20130/summary.html

Comparison Summary:

You potentially added 38 lines to the logs
Reco comparison results: 3401 differences found in the comparisons
DQMHistoTests: Total files compared: 24
DQMHistoTests: Total histograms compared: 1833626
DQMHistoTests: Total failures: 33458
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1799988
DQMHistoTests: Total skipped: 180
DQMHistoTests: Total Missing objects: 0
Checked 98 log files, 14 edm output root files, 24 DQM output files

cmsbuild · 2017-05-26T13:10:37Z

Pull request #18957 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again.

folguera · 2017-05-26T13:11:07Z

@fwyzard, @Martin-Grunewald I followed option 2 from Andrea's suggestion.

fwyzard · 2017-05-26T13:18:02Z

@cmsbuild please test

cmsbuild · 2017-05-26T13:18:23Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20135/console Started: 2017/05/26 15:20

fwyzard · 2017-05-26T13:20:51Z

@folguera I think you are officially the second person in CMS to make use of this possibility :-)

cmsbuild · 2017-05-26T14:04:22Z

+1
Tested at: c4800fc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18957/20135/summary.html

cmsbuild · 2017-05-26T14:04:25Z

Comparison job queued.

Martin-Grunewald · 2017-05-26T16:16:31Z

+1

cmsbuild · 2017-05-26T16:16:48Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

cmsbuild · 2017-05-26T16:57:07Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18957/20135/summary.html

Comparison Summary:

You potentially added 109 lines to the logs
Reco comparison results: 3415 differences found in the comparisons
DQMHistoTests: Total files compared: 24
DQMHistoTests: Total histograms compared: 1833626
DQMHistoTests: Total failures: 47794
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1785652
DQMHistoTests: Total skipped: 180
DQMHistoTests: Total Missing objects: 0
Checked 98 log files, 14 edm output root files, 24 DQM output files

davidlange6 · 2017-05-27T07:37:36Z

+1

bug fix to avoid running twice on the same L1

fa43be2

cmsbuild added this to the CMSSW_9_2_X milestone May 26, 2017

cmsbuild added comparison-pending hlt-pending orp-pending pending-signatures tests-pending labels May 26, 2017

cmsbuild added tests-started and removed tests-pending labels May 26, 2017

cmsbuild added tests-approved and removed tests-started labels May 26, 2017

folguera commented May 26, 2017

View reviewed changes

cmsbuild added comparison-available and removed comparison-pending labels May 26, 2017

added OptionalNode to avoid crashing old configurations

c4800fc

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels May 26, 2017

cmsbuild added tests-started and removed tests-pending labels May 26, 2017

cmsbuild added tests-approved and removed tests-started labels May 26, 2017

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels May 26, 2017

cmsbuild added comparison-available and removed comparison-pending labels May 26, 2017

cmsbuild added orp-approved and removed orp-pending labels May 27, 2017

cmsbuild merged commit cc64914 into cms-sw:master May 27, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MuonHLT IterL3 reconstruction: bug fix to avoid running twice on the same L1 #18957

MuonHLT IterL3 reconstruction: bug fix to avoid running twice on the same L1 #18957

folguera commented May 26, 2017

cmsbuild commented May 26, 2017

fwyzard commented May 26, 2017 •

edited

cmsbuild commented May 26, 2017 •

edited

fwyzard commented May 26, 2017

cmsbuild commented May 26, 2017

cmsbuild commented May 26, 2017

folguera May 26, 2017 •

edited

Martin-Grunewald May 26, 2017

fwyzard commented May 26, 2017

Martin-Grunewald commented May 26, 2017

cmsbuild commented May 26, 2017

cmsbuild commented May 26, 2017

folguera commented May 26, 2017

fwyzard commented May 26, 2017

cmsbuild commented May 26, 2017 •

edited

fwyzard commented May 26, 2017

cmsbuild commented May 26, 2017

cmsbuild commented May 26, 2017

Martin-Grunewald commented May 26, 2017

cmsbuild commented May 26, 2017

cmsbuild commented May 26, 2017

davidlange6 commented May 27, 2017

MuonHLT IterL3 reconstruction: bug fix to avoid running twice on the same L1 #18957

MuonHLT IterL3 reconstruction: bug fix to avoid running twice on the same L1 #18957

Conversation

folguera commented May 26, 2017

cmsbuild commented May 26, 2017

fwyzard commented May 26, 2017 • edited

cmsbuild commented May 26, 2017 • edited

fwyzard commented May 26, 2017

cmsbuild commented May 26, 2017

cmsbuild commented May 26, 2017

folguera May 26, 2017 • edited

Choose a reason for hiding this comment

Martin-Grunewald May 26, 2017

Choose a reason for hiding this comment

fwyzard commented May 26, 2017

Martin-Grunewald commented May 26, 2017

cmsbuild commented May 26, 2017

cmsbuild commented May 26, 2017

folguera commented May 26, 2017

fwyzard commented May 26, 2017

cmsbuild commented May 26, 2017 • edited

fwyzard commented May 26, 2017

cmsbuild commented May 26, 2017

cmsbuild commented May 26, 2017

Martin-Grunewald commented May 26, 2017

cmsbuild commented May 26, 2017

cmsbuild commented May 26, 2017

davidlange6 commented May 27, 2017

fwyzard commented May 26, 2017 •

edited

cmsbuild commented May 26, 2017 •

edited

folguera May 26, 2017 •

edited

cmsbuild commented May 26, 2017 •

edited