Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix HLT rate monitoring for CMSSW 9.2.x #18980

Merged
merged 5 commits into from May 28, 2017

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 27, 2017

  • drop obsolete TriggerJSONMonitoring
  • rewrite HLTriggerJSONMonitoring and L1TriggerJSONMonitoring to properly handle multiple framework streams
  • check for conflicting values in the prescale column index

@fwyzard
Copy link
Contributor Author

fwyzard commented May 27, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20150/console Started: 2017/05/27 10:30

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

HLTrigger/JSONMonitoring

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented May 27, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18980/20150/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1754 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833558
  • DQMHistoTests: Total failures: 23263
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1810115
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 99409ac into cms-sw:master May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants