Offline DQM for Top HLT #18981

defranchis · 2017-05-27T08:38:13Z

A few features are not yet implemented and will be added in the upcoming days

cmsbuild · 2017-05-27T08:38:32Z

A new Pull Request was created by @defranchis (Matteo Defranchis) for master.

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

mtosi · 2017-05-29T10:38:00Z

DQMOffline/Trigger/python/TopMonitoring_cff.py

+eleJet_jet.eleSelection = cms.string('pt>50 & abs(eta)<2.1')
+eleJet_jet.jetSelection = cms.string('pt>30 & abs(eta)<2.4')
+eleJet_jet.numGenericTriggerEventPSet.hltPaths = cms.vstring('HLT_Ele30_eta2p1_WPTight_Gsf_CentralPFJet35_EleCleaned_v*')
+eleJet_jet.denGenericTriggerEventPSet.hltPaths = cms.vstring('HLT_Ele30_eta2p1_WPTight_Gsf_v*',


are you sure those triggers are available in 2017 HLT menu ?

HLT_Ele30_eta2p1_WPTight_Gsf_CentralPFJet35_EleCleaned_v1 is in /dev/CMSSW_9_1_0/HLT
https://its.cern.ch/jira/browse/CMSHLT-1268

mtosi · 2017-05-29T10:38:56Z

DQMOffline/Trigger/python/TopMonitoring_cff.py

+eleJet_jet.numGenericTriggerEventPSet.hltPaths = cms.vstring('HLT_Ele30_eta2p1_WPTight_Gsf_CentralPFJet35_EleCleaned_v*')
+eleJet_jet.denGenericTriggerEventPSet.hltPaths = cms.vstring('HLT_Ele30_eta2p1_WPTight_Gsf_v*',
+                                                             'HLT_Ele35_WPTight_Gsf_v*',
+                                                             'HLT_Ele38_WPTight_Gsf_v*',


38 and 40 are monitored by EGM tag-n-probe
while 35 is not monitored (?) and 30 seems to not be available, so far

35 GeV was an oversight and will be added to EGM tag-n-probe. Thanks for the spot

mtosi · 2017-05-29T10:39:26Z

DQMOffline/Trigger/python/TopMonitoring_cff.py

+eleJet_ele.eleSelection = cms.string('pt>25 & abs(eta)<2.1')
+eleJet_ele.jetSelection = cms.string('pt>50 & abs(eta)<2.4')
+eleJet_ele.numGenericTriggerEventPSet.hltPaths = cms.vstring('HLT_Ele30_eta2p1_WPTight_Gsf_CentralPFJet35_EleCleaned_v*')
+eleJet_ele.denGenericTriggerEventPSet.hltPaths = cms.vstring('HLT_PFJet60_v*')


who is monitoring this ?

The BTV and SMP groups will take care of the HLT_PFJet* paths

mtosi · 2017-05-29T10:44:10Z

DQMOffline/Trigger/python/TopMonitoring_cff.py

+topDiElectronHLTValidation.eleSelection = cms.string('pt>20 & abs(eta)<2.5  & (dr03TkSumPt+dr03EcalRecHitSumEt+dr03HcalTowerSumEt)/pt < 0.1')
+topDiElectronHLTValidation.muoSelection = cms.string('pt>20 & abs(eta)<2.4 & (pfIsolationR04.sumChargedHadronPt+pfIsolationR04.sumPhotonEt+pfIsolationR04.sumNeutralHadronEt)/pt < 0.12')   
+topDiElectronHLTValidation.jetSelection = cms.string('pt>30 & abs(eta)<2.5')
+topDiElectronHLTValidation.numGenericTriggerEventPSet.hltPaths = cms.vstring(['HLT_Ele12_Ele23_CaloIdL_TrackIdL_IsoVL_DZ_v*'])


are you sure this path is available in 2017 ?

it is in /dev/CMSSW_9_1_0/HLT

which JIRA ticket ?

sorry I actually replied to the wrong comment. I have to ask the responsibles for the di-lepton

mtosi · 2017-05-29T11:15:55Z

what about HLT_Ele30_eta2p1_WPTight_Gsf_CentralPFJet35_EleCleaned ?

mtosi · 2017-05-29T13:24:57Z

DQMOffline/Trigger/plugins/TopMonitor.cc

@@ -0,0 +1,541 @@
+#include "DQMOffline/Trigger/plugins/TopMonitor.h"


I think you should update the name of this class
unless you are going to add observables really TOP dependent

In principle top dependent variables can be added. I would keep it as it is for the moment...

mtosi · 2017-05-29T13:54:19Z

DQMOffline/Trigger/plugins/TopMonitor.cc

+  , ls_binning_           ( getHistoLSPSet (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet>   ("lsPSet")     ) )
+  , phi_binning_          ( getHistoPSet   (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet>   ("phiPSet")    ) )
+  , pt_binning_           ( getHistoPSet   (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet>   ("ptPSet")    ) )
+  , eta_binning_          ( getHistoPSet   (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet>   ("etaPSet")    ) )


I think it should be variable binning

I am going to add the variable binning in the next days

please, we have to converge on this PR before the end of this week
thanks !

I'm confident we will

mtosi · 2017-05-29T13:54:22Z

DQMOffline/Trigger/plugins/TopMonitor.cc

+  , met_binning_          ( getHistoPSet   (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet>   ("metPSet")    ) )
+  , ls_binning_           ( getHistoLSPSet (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet>   ("lsPSet")     ) )
+  , phi_binning_          ( getHistoPSet   (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet>   ("phiPSet")    ) )
+  , pt_binning_           ( getHistoPSet   (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet>   ("ptPSet")    ) )


I think it should be variable binning

same as above

mtosi · 2017-05-29T13:54:33Z

DQMOffline/Trigger/plugins/TopMonitor.cc

+  , phi_binning_          ( getHistoPSet   (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet>   ("phiPSet")    ) )
+  , pt_binning_           ( getHistoPSet   (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet>   ("ptPSet")    ) )
+  , eta_binning_          ( getHistoPSet   (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet>   ("etaPSet")    ) )
+  , HT_binning_           ( getHistoPSet   (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet>   ("htPSet")    ) )


I think it should be variable binning

same as above

mtosi · 2017-05-29T13:55:10Z

DQMOffline/Trigger/python/TopMonitoring_Client_cff.py

+    verbose        = cms.untracked.uint32(0), # Set to 2 for all messages
+    resolution     = cms.vstring(),
+    efficiency     = cms.vstring(
+        "effic_metME       'efficiency vs MET; MET [GeV]; efficiency' metME_numerator       metME_denominator",


I think you can play w/ the python

I agree, but I think it would make the code less easily understandable for others who might want to edit or use it

please change all cms.EDAnalyzer("DQMGenericClient" instances to cms.EDProducer("DQMGenericClient" to adapt to #18751

The tests and integration will fail otherwise.

sorry because I'm reverse engineering these changes I think I got them wrong
cms.EDAnalyzer("DQMGenericClient",

to

DQMEDHarvester("DQMGenericClient",

and you need to have

from DQMServices.Core.DQMEDHarvester import DQMEDHarvester

in your config

Thanks Sam. How can I get relevant updates for that? I would like to keep testing my code with my current setup

@Sam-Harper done!

cmsbuild · 2017-05-30T09:19:51Z

Pull request #18981 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

adding variable binning + multiplicity histograms

cmsbuild · 2017-05-30T15:06:30Z

Pull request #18981 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

cmsbuild · 2017-05-30T17:41:18Z

Pull request #18981 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

cmsbuild · 2017-05-31T08:42:22Z

Pull request #18981 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

cmsbuild · 2017-05-31T16:03:10Z

Pull request #18981 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

mtosi · 2017-05-31T16:17:25Z

@defranchis we are done, aren't we ?

cmsbuild · 2017-06-09T20:26:16Z

+1
Tested at: 576c9f0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18981/20475/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
576c9f0
856e68b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18981/20475/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18981/20475/git-merge-result

cmsbuild · 2017-06-09T20:26:19Z

Comparison job queued.

cmsbuild · 2017-06-09T23:54:19Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18981/20475/summary.html

Comparison Summary:

You potentially added 140 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1872323
DQMHistoTests: Total failures: 34695
DQMHistoTests: Total nulls: 130
DQMHistoTests: Total successes: 1837325
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

mtosi · 2017-06-12T08:27:27Z

@dmitrijus, if you are fine w/ this, ca you please sign it ?
thanks !

mtosi · 2017-06-12T09:29:11Z

I still do not see
HLT_PFHT430_SixJet40
HLT_PFHT350

defranchis · 2017-06-12T09:41:02Z

@mtosi both paths are monitored in TopMonitoring_cff.py

mtosi · 2017-06-12T09:52:30Z

what about
HLT_HT300PT30_QuadJet_75_60_45_40_TripeCSV_p07_v*
HLT_HT300PT30_QuadJet_75_60_45_40_v*
?

jira ticket https://its.cern.ch/jira/browse/CMSHLT-1352
points to this PR (?!?!?!)

defranchis · 2017-06-12T09:57:50Z

There is an open PR to this branch defranchis#18 . As we discussed, the idea is to include those changes in #19119 instead

mtosi · 2017-06-12T10:13:47Z

fine,
what is needed is to be in a CMSSW PR ....

dmitrijus · 2017-06-12T13:53:04Z

+1

cmsbuild · 2017-06-12T13:53:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

dmitrijus · 2017-06-12T13:53:29Z

(close if changes are included elsewhere)

davidlange6 · 2017-06-13T08:23:49Z

shall we close this in favor of #19119?

defranchis · 2017-06-13T08:25:57Z

we should merge this one first, then #19119

defranchis · 2017-06-13T08:28:40Z

@davidlange6 but actually we could also close this in favour of #19119 as you suggested

davidlange6 · 2017-06-13T08:45:28Z

either we close this, or review this and rebase 19119 after this goes in - up to you

…

On Jun 13, 2017, at 10:28 AM, Matteo Defranchis ***@***.***> wrote: @davidlange6 but actually we could also close this in favour of #19119 as you suggested — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

fwyzard · 2017-06-14T11:30:02Z

The paths

HLT_PFHT380_SixJet32_v*
HLT_PFHT430_SixJet40_v

are not being monitored, and will not be included in the HLT menu.

In fact this also invalidates all the monitoring that use them as reference...

defranchis · 2017-06-14T11:53:25Z

@fwyzard I will add them in #19119

davidlange6 · 2017-06-16T10:38:53Z

seems this is superseded by #19119

Offline DQM for Top HLT

b8c78ae

cmsbuild added this to the CMSSW_9_2_X milestone May 27, 2017

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels May 27, 2017

mtosi reviewed May 29, 2017

View reviewed changes

adding electron isolation for ele+jets

552890e

defranchis added 2 commits May 30, 2017 17:02

adding variable binning + multiplicity histograms

8173416

Merge pull request #5 from defranchis/DQM-try-to-cherrypick

01b00c3

adding variable binning + multiplicity histograms

adding 2D histograms and efficiencies

b68cbb0

renaming directories

26414c6

updating from EDAnalyzer to DQMEDHarvester

5303a4a

cmsbuild added tests-started and removed tests-pending labels Jun 9, 2017

cmsbuild added tests-approved and removed tests-started labels Jun 9, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jun 9, 2017

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jun 12, 2017

davidlange6 closed this Jun 16, 2017

		@@ -0,0 +1,541 @@
		#include "DQMOffline/Trigger/plugins/TopMonitor.h"

Offline DQM for Top HLT #18981

Offline DQM for Top HLT #18981

Conversation

defranchis commented May 27, 2017

cmsbuild commented May 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

defranchis May 30, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mtosi commented May 29, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented May 30, 2017

cmsbuild commented May 30, 2017

cmsbuild commented May 30, 2017

cmsbuild commented May 31, 2017

cmsbuild commented May 31, 2017

mtosi commented May 31, 2017

cmsbuild commented Jun 9, 2017

cmsbuild commented Jun 9, 2017

cmsbuild commented Jun 9, 2017

mtosi commented Jun 12, 2017

mtosi commented Jun 12, 2017

defranchis commented Jun 12, 2017

mtosi commented Jun 12, 2017

defranchis commented Jun 12, 2017 • edited

mtosi commented Jun 12, 2017

dmitrijus commented Jun 12, 2017

cmsbuild commented Jun 12, 2017

dmitrijus commented Jun 12, 2017

davidlange6 commented Jun 13, 2017

defranchis commented Jun 13, 2017 • edited

defranchis commented Jun 13, 2017

davidlange6 commented Jun 13, 2017 via email

fwyzard commented Jun 14, 2017 • edited

defranchis commented Jun 14, 2017

davidlange6 commented Jun 16, 2017

defranchis May 30, 2017 •

edited

defranchis commented Jun 12, 2017 •

edited

defranchis commented Jun 13, 2017 •

edited

fwyzard commented Jun 14, 2017 •

edited