Adding anode DB suppression status to the rechits

[igv4321]

This change ensures that the status of "anode" in the HF reco will be reflected in the combined PMT rechit whenever that anode is flagged bad in the relevant DB calibration table. In the previous version of the code, this was done only if the anode was actually present in the digis. With this update, the status will be propagated to the rechit even if that anode is not in the data stream (but its neighbor anode is). This will make a difference for "dead" channels flagged in DB.

Since, at the moment, there are no bad channels flagged in the DB for HF, this PR will not change any relval results.

[cmsbuild]

A new Pull Request was created by @igv4321 (Igor Volobouev) for master.

It involves the following packages:

RecoLocalCalo/HcalRecAlgos

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@mariadalfonso, @argiro this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20168/console Started: 2017/05/29 19:01

[cmsbuild]

+1
Tested at: 24eca6c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18996/20168/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18996/20168/summary.html

Comparison Summary:

• You potentially added 200 lines to the logs
• Reco comparison results: 3388 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1840355
• DQMHistoTests: Total failures: 34236
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1805939
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[perrotta]

+1
Changes to the code reflects what is in the description
No changes expected in output, no changes observed

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1