Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run2-hcx127 Correct the output cff sepecification for 2 minimum bias paths #19033

Merged
merged 2 commits into from Jun 6, 2017
Merged

Run2-hcx127 Correct the output cff sepecification for 2 minimum bias paths #19033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a69ac0
Correct the output tags
May 31, 2017
97bdf07
Update the MinBias trigger path
Jun 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Calibration/HcalAlCaRecoProducers/python/ALCARECOHcalCalMinBiasHI_Output_cff.py
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@
'keep HBHERecHitsSorted_hbhereco_*_*',
'keep HORecHitsSorted_horeco_*_*',
'keep HFRecHitsSorted_hfreco_*_*',
'keep HFRecHitsSorted_hfrecoMBspecial_*_*',
'keep HFRecHitsSorted_hfrecoMBNZS_*_*',
'keep HBHERecHitsSorted_hbherecoNoise_*_*',
'keep HORecHitsSorted_horecoNoise_*_*',
'keep HFRecHitsSorted_hfrecoNoise_*_*')
Expand Down
3 changes: 2 additions & 1 deletion Calibration/HcalAlCaRecoProducers/python/ALCARECOHcalCalMinBiasHI_cff.py
View file
Open in desktop
Expand Up @@ -26,7 +26,8 @@

import RecoLocalCalo.HcalRecProducers.HcalSimpleReconstructor_ho_cfi

seqALCARECOHcalCalMinBias = cms.Sequence(hcalminbiasHLT*hcalDigiAlCaMB*gtDigisAlCaMB*hbherecoNoise*hfrecoNoise*hfrecoMBNZS*horecoNoise)
seqALCARECOHcalCalMinBiasDigi = cms.Sequence(hcalminbiasHLT*hcalDigiAlCaMB*gtDigisAlCaMB)
Copy link
Contributor

@arunhep arunhep Jun 6, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda what is the purpose of dividing the whole sequence into two parts? This question applies to other file as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is needed because later on one updates one of the sequences. With a combined one it was doing the changes wrongly which was noticed by Olga Kodolova

seqALCARECOHcalCalMinBias = cms.Sequence(hbherecoNoise*hfrecoNoise*hfrecoMBNZS*horecoNoise)

import RecoLocalCalo.HcalRecProducers.hfprereco_cfi
hfprerecoMBNZS = RecoLocalCalo.HcalRecProducers.hfprereco_cfi.hfprereco.clone(
Expand Down
7 changes: 3 additions & 4 deletions Calibration/HcalAlCaRecoProducers/python/ALCARECOHcalCalMinBias_Output_cff.py
View file
Open in desktop
Expand Up @@ -10,10 +10,9 @@
),
outputCommands = cms.untracked.vstring(
'keep *_gtDigisAlCaMB_*_*',
'keep HBHERecHitsSorted_hbherecoMB_*_*',
'keep HORecHitsSorted_horecoMB_*_*',
'keep HFRecHitsSorted_hfrecoMB_*_*',
'keep HFRecHitsSorted_hfrecoMBspecial_*_*',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was this collection with label hfrecoMBspecial ? May be a description of pull-request could be a better way to describe the changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a special collection with HF data reconstructed with different parameter sets

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"special" is no longer used. Cant you see these lines belong to the older version - not the new one

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing "special" is not the point but i want to understand better that with the replaced label what will be the consequences?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not produce the collection any more. The collections produced are with label NZS and these are the ones which are used in subsequent analysis. So this is a simple clean up process. The consequence of the removal is to remove misinformation which you fell for.

'keep HBHERecHitsSorted_hbherecoMBNZS_*_*',
'keep HORecHitsSorted_horecoMBNZS_*_*',
'keep HFRecHitsSorted_hfrecoMBNZS_*_*',
'keep HBHERecHitsSorted_hbherecoNoise_*_*',
'keep HORecHitsSorted_horecoNoise_*_*',
'keep HFRecHitsSorted_hfrecoNoise_*_*')
Expand Down
6 changes: 4 additions & 2 deletions Calibration/HcalAlCaRecoProducers/python/ALCARECOHcalCalMinBias_cff.py
View file
Open in desktop
Expand Up @@ -55,8 +55,10 @@
hfrecoMBNZS.tsFromDB = cms.bool(False)
hfrecoMBNZS.dropZSmarkedPassed = cms.bool(False)

seqALCARECOHcalCalMinBias = cms.Sequence(hcalminbiasHLT*hcalDigiAlCaMB*gtDigisAlCaMB*hbherecoMBNZS*horecoMBNZS*hbherecoNoise*hfrecoNoise*hfrecoMBNZS*horecoNoise)
seqALCARECOHcalCalMinBiasNoHLT = cms.Sequence(hcalDigiAlCaMB*gtDigisAlCaMB*hbherecoMBNZS*horecoMBNZS*hbherecoNoise*hfrecoNoise*hfrecoMBNZS*horecoNoise)
seqALCARECOHcalCalMinBiasDigi = cms.Sequence(hcalminbiasHLT*hcalDigiAlCaMB*gtDigisAlCaMB)
seqALCARECOHcalCalMinBiasDigiNoHLT = cms.Sequence(hcalDigiAlCaMB*gtDigisAlCaMB)

seqALCARECOHcalCalMinBias = cms.Sequence(hbherecoMBNZS*horecoMBNZS*hbherecoNoise*hfrecoNoise*hfrecoMBNZS*horecoNoise)

import RecoLocalCalo.HcalRecProducers.hfprereco_cfi
hfprerecoNoise = RecoLocalCalo.HcalRecProducers.hfprereco_cfi.hfprereco.clone(
Expand Down
2 changes: 1 addition & 1 deletion Configuration/StandardSequences/python/AlCaRecoStream_SpecialsHI_cff.py
View file
Open in desktop
Expand Up @@ -51,7 +51,7 @@

from DQMOffline.Configuration.AlCaRecoDQMHI_cff import *

pathALCARECOHcalCalMinBias = cms.Path(seqALCARECOHcalCalMinBias*ALCARECOHcalCalPhisymDQM)
pathALCARECOHcalCalMinBias = cms.Path(seqALCARECOHcalCalMinBiasDigi*seqALCARECOHcalCalMinBias*ALCARECOHcalCalPhisymDQM)

from Configuration.EventContent.AlCaRecoOutput_cff import *

Expand Down
2 changes: 1 addition & 1 deletion Configuration/StandardSequences/python/AlCaRecoStream_Specials_cff.py
View file
Open in desktop
Expand Up @@ -44,7 +44,7 @@
# HCAL calibration with min.bias
from Calibration.HcalAlCaRecoProducers.ALCARECOHcalCalMinBias_cff import *

pathALCARECOHcalCalMinBias = cms.Path(seqALCARECOHcalCalMinBias*ALCARECOHcalCalPhisymDQM)
pathALCARECOHcalCalMinBias = cms.Path(seqALCARECOHcalCalMinBiasDigi*seqALCARECOHcalCalMinBias*ALCARECOHcalCalPhisymDQM)

from Configuration.EventContent.AlCaRecoOutput_cff import *

Expand Down