Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injection of workflows without approving them #19062

Merged
merged 2 commits into from Jun 2, 2017

Conversation

fabozzi
Copy link
Contributor

@fabozzi fabozzi commented Jun 1, 2017

We inject workflows without approving at the same time. Approval of workflows will be done by the submitter via reqmgr2 interface. This procedure comes with removal of 4h "grace" period in Unified before assigning the workflows.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2017

A new Pull Request was created by @fabozzi for master.

It involves the following packages:

Configuration/PyReleaseValidation

@kkousour, @kpedro88, @fabozzi, @cmsbuild, @GurpreetSinghChahal, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @ebrondol, @ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@fabozzi
Copy link
Contributor Author

fabozzi commented Jun 1, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20283/console Started: 2017/06/01 15:47

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19062/20283/summary.html

Comparison Summary:

  • You potentially added 90 lines to the logs
  • Reco comparison results: 3399 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1789419
  • DQMHistoTests: Total failures: 46539
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1742707
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@fabozzi
Copy link
Contributor Author

fabozzi commented Jun 1, 2017

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 1, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

hi @fabozzi - could you just remove the line instead of commenting it out. thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2017

Pull request #19062 was updated. @kkousour, @kpedro88, @fabozzi, @cmsbuild, @GurpreetSinghChahal, @davidlange6 can you please check and sign again.

@fabozzi
Copy link
Contributor Author

fabozzi commented Jun 2, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20297/console Started: 2017/06/02 09:40

@fabozzi
Copy link
Contributor Author

fabozzi commented Jun 2, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19062/20297/summary.html

Comparison Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 1669 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1789234
  • DQMHistoTests: Total failures: 37407
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1751654
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 2, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e980a4e into cms-sw:master Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants