Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 1897 #1908

Merged
merged 6 commits into from Dec 20, 2013
Merged

Merge 1897 #1908

merged 6 commits into from Dec 20, 2013

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Dec 20, 2013

This should be exactly like 1897, but now mergiable. There seems to be white space issues which are creating troubles.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_0_X.

Merge 1897

It involves the following packages:

CommonTools/ParticleFlow
DQMOffline/Alignment
JetMETCorrections/Configuration
JetMETCorrections/Modules
PhysicsTools/PatAlgos
RecoEgamma/EgammaHLTProducers
RecoJets/Configuration
RecoJets/JetProducers
Validation/RecoJets

@perrotta, @cmsbuild, @thspeer, @danduggan, @fwyzard, @rovere, @Martin-Grunewald, @anton-a, @nclopezo, @deguio, @slava77, @vadler, @eliasron can you please review it and eventually sign? Thanks.
@TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@vadler
Copy link

vadler commented Dec 20, 2013

+1
(tested #1897 , no AT code changes here)

@ktf
Copy link
Contributor Author

ktf commented Dec 20, 2013

Ok. @slava77 is right. I picked up the wrong side of history. This (updated) should have all the right choices, as suggested by @vadler and confirmed by @slava77.

@slava77
Copy link
Contributor

slava77 commented Dec 20, 2013

Giulio, if you checked the contents are the same as #1897 , then feel free to bypass

@ktf
Copy link
Contributor Author

ktf commented Dec 20, 2013

I'm checking this right now.

@cmsbuild
Copy link
Contributor

Pull request #1908 was updated. @perrotta, @cmsbuild, @thspeer, @danduggan, @fwyzard, @rovere, @Martin-Grunewald, @anton-a, @nclopezo, @deguio, @slava77, @vadler, @eliasron can you please check and sign again.

1 similar comment
@cmsbuild
Copy link
Contributor

Pull request #1908 was updated. @perrotta, @cmsbuild, @thspeer, @danduggan, @fwyzard, @rovere, @Martin-Grunewald, @anton-a, @nclopezo, @deguio, @slava77, @vadler, @eliasron can you please check and sign again.

@vadler
Copy link

vadler commented Dec 20, 2013

+1

@cmsbuild
Copy link
Contributor

Pull request #1908 was updated. @perrotta, @cmsbuild, @thspeer, @danduggan, @fwyzard, @rovere, @Martin-Grunewald, @anton-a, @nclopezo, @deguio, @slava77, @vadler, @eliasron can you please check and sign again.

@vadler
Copy link

vadler commented Dec 20, 2013

+1

@ktf
Copy link
Contributor Author

ktf commented Dec 20, 2013

Ok. This one has the correct merge, as done by @Slava:

Conflicting bits are resolved to:

useRho = cms.bool(True),
rho = cms.InputTag('fixedGridRhoFastjetAllCalo'),

and

fixedGridRhoFastjetCentralChargedPileUp+
fixedGridRhoFastjetCentralNeutral+

which is what slava has in:

https://github.com/slava77/cmssw/blob/5a70016b3e310d262309211092e896f552954eca/PhysicsTools/PatAlgos/python/recoLayer0/jetCorrFactors_cfi.py

and

https://github.com/slava77/cmssw/blob/5a70016b3e310d262309211092e896f552954eca/RecoJets/Configuration/python/RecoJets_cff.py

ktf added a commit that referenced this pull request Dec 20, 2013
@ktf ktf merged commit e7ac179 into cms-sw:CMSSW_7_0_X Dec 20, 2013
@slava77
Copy link
Contributor

slava77 commented Dec 20, 2013

merging of merges is easily turning into a mess.
starting from 1804+1848+1863 in the order fitting the current state of the head may be much easier

@ktf
Copy link
Contributor Author

ktf commented Dec 20, 2013

Indeed, sorry. This mess is completely my fault when approving 1848.
Hopufully I managed to to everything as you did. Sorry again.

@ktf ktf deleted the merge-1897 branch June 4, 2014 07:34
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
gmp-static: set --host and --build to for a generic build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants