OnlineDQM : Add Quality Tests for L1T Muons #19087
Conversation
|
A new Pull Request was created by @stahlleiton (Andre Stahl) for master. It involves the following packages: DQM/L1TMonitorClient @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 |
|
|
||
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
| l1TStage2BMTFQualityTests = cms.EDAnalyzer("QualityTester", |
There was a problem hiding this comment.
shouldn't this be a harvester as well?
There was a problem hiding this comment.
Currently the QualityTester class is still an edm::EDAnalyzer and was not changed by PR 18751 , so I am not sure if the class should be changed to a DQMEDHarvester.
There was a problem hiding this comment.
is there not a definitive recipe?
@dmitrijus
There was a problem hiding this comment.
@davidlange6 Not yet. Eventually, QualityTester should be migrated into a harvester, eventually...
But this is out of scope for this PR.
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Comparison job queued. |
|
Pull request #19087 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
Description:
This PR add to CMSSW a set of new Quality Tests applied on each L1T Muon subsystem, and it includes the following list of features:
NOTE: Since some of the QTs make use of the 2D Chi2 Quality Test introduce in CMSSW PR 18965, this PR depends on 18965 and will require to be tested with cmsswPR #18965 , or otherwise the tests will most likely fail.
@thomreis @bortigno