Run2-TB31 Modify the analyzer to record information for the passive part of the setup #19095
Conversation
|
@cmsbuild Please test |
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: SimG4CMS/HGCalTestBeam @cmsbuild, @civanch, @mdhildreth, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
bsunanda
changed the title
|
Comparison is ready Comparison Summary:
|
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1 |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
|
||
| std::vector<float> hgcPassiveEEEnergy, hgcPassiveFHEnergy, hgcPassiveBHEnergy; | ||
| std::vector<std::string> hgcPassiveEEName, hgcPassiveFHName, hgcPassiveBHName; | ||
| std::vector<Int_t> hgcPassiveEEID, hgcPassiveFHID, hgcPassiveBHID; |
There was a problem hiding this comment.
hi @bsunanda - please use int rather than Int_t
There was a problem hiding this comment.
Doing that and I am resubmitting the PR
|
Pull request #19095 was updated. @cmsbuild, @civanch, @mdhildreth, @kpedro88, @davidlange6 can you please check and sign again. |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
merge |
Add 3 more elements to the tree for each type of TB detector (EE, FH and BH)