Run2-sim08 Enabling depth studies in Ecal crystal

[bsunanda]

There was ambiguity of depth index in earlier version. Now if StoreRadiationLength is set true, it stores # of radiation lengths in unit of ScaleRadiationLength as depth; else if StoreLayerTimeSim is set true, it stores time in units of TimeSliceUnit; else it stores 0, 1, 2 for crystal volume, primary & secondary APD volumes

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

SimG4CMS/Calo
SimG4Core/Application

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20335/console Started: 2017/06/05 20:18

[cmsbuild]

+1
Tested at: e0a34b1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19099/20335/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19099/20335/summary.html

Comparison Summary:

• You potentially added 165 lines to the logs
• Reco comparison results: 4518 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1837605
• DQMHistoTests: Total failures: 47939
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1789493
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[civanch]

@bsunanda , why a new value 1.0 is needed? Radiation length is a const for a given calorimeter. You mean a possibility to have an effective rad length, which will be tuned to data?

Concerning EcalSD - it seems that the class has some ineffective patterns, like string comparison at each step. Is this update for 2023 or for early workflows?

[bsunanda]

@civanch The length is stored in 16 bit integer and not in a float or double. People requiring a better precision can scale it by a factor for example 100 and can still fit in 16 bit integers. This is the purpose. There are some requirements for this - these are specific studies.
Regarding the string comparisons - they are all converted from string to int (pointer values) during initialization. All string comparisons are done during initialization - do you think any special action is needed for this

[civanch]

+1
@bsunanda , even comparison with integer seems not optimal. More effective is check for a G4Region, for that a separate regions. I would propose to add extra regions and read out logical volume data structures, of course, in a separate PR. Concerning radiation length, I still am not sure why extra double parameter is added to g4SimHits with the default value 1.0. Do you foresee that it will be different?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

hi @bsunanda - do we need the commented out lines?

[bsunanda]

That watcher is not working right now. I shall work on it later - make it work and then uncomment these lines

[davidlange6]

+1