Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD ExprAlgo Merge with Core #19106

Merged
merged 2 commits into from Jun 7, 2017
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jun 6, 2017

  • DD ExprAlgo package cleanup
  • Move remaining class to DD Core package

Note: it is based on #19093 PR

@ianna
Copy link
Contributor Author

ianna commented Jun 6, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20348/console Started: 2017/06/06 14:35

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Alignment/CocoaFit
DetectorDescription/Algorithm
DetectorDescription/Base
DetectorDescription/Core
DetectorDescription/ExprAlgo
DetectorDescription/OfflineDBLoader
DetectorDescription/Parser
DetectorDescription/RegressionTest
Geometry/CaloEventSetup
Geometry/EcalCommonData
Geometry/EcalTestBeam
Geometry/ForwardCommonData
Geometry/HGCalCommonData
Geometry/HcalAlgo
Geometry/HcalCommonData
Geometry/HcalTestBeamData
Geometry/MTCCTrackerCommonData
Geometry/MuonCommonData
Geometry/TrackerCommonData
Geometry/TrackerGeometryBuilder
Geometry/TrackerNumberingBuilder
Geometry/VeryForwardGeometryBuilder
GeometryReaders/XMLIdealGeometryESSource
MagneticField/GeomBuilder
SLHCUpgradeSimulations/Geometry
SimG4CMS/Forward

@perrotta, @ghellwig, @civanch, @Dr15Jones, @arunhep, @ianna, @mdhildreth, @cmsbuild, @franzoni, @kpedro88, @cerminar, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @namapane, @makortel, @tocheng, @argiro, @Martin-Grunewald, @ptcox, @VinInn, @mschrode, @ebrondol, @ghugo83, @mmusich, @venturia this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

Comparison job queued.

@ianna
Copy link
Contributor Author

ianna commented Jun 6, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19106/20348/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1837571
  • DQMHistoTests: Total failures: 32570
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1804828
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jun 6, 2017

+1

for #19106 3ba21e2

@civanch
Copy link
Contributor

civanch commented Jun 7, 2017

+1

@davidlange6 davidlange6 merged commit 0e11a9b into cms-sw:master Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants