Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vector include to EventVariables.h #19107

Merged

Conversation

Teemperor
Copy link
Contributor

The v_sector member is using std::vector, so we need the definition of std::vector
in this header.

The v_sector member is using std::vector, so we need the definition
in this header.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

Alignment/APEEstimation

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@arunhep
Copy link
Contributor

arunhep commented Jun 6, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20359/console Started: 2017/06/06 15:42

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19107/20359/summary.html

Comparison Summary:

  • You potentially added 60 lines to the logs
  • Reco comparison results: 3374 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1837639
  • DQMHistoTests: Total failures: 32855
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1804611
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Jun 6, 2017

+1
trivial change of code

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8ae751d into cms-sw:master Jun 7, 2017
@Teemperor Teemperor deleted the FixMissingIncludeEventVariables.h branch December 19, 2017 08:47
@Teemperor Teemperor restored the FixMissingIncludeEventVariables.h branch December 19, 2017 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants