Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include to MessageLogger.h to EcalEBTrigPrimTestAlgo.h #19121

Conversation

Teemperor
Copy link
Contributor

We use edm::LogError here, so we also need to include the header
that is providing this logging mechanism.

We use edm::LogError here, so we also need to include the header
that is providing this logging mechanism.
@Teemperor
Copy link
Contributor Author

Part of the work going on regarding issue #15248

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

SimCalorimetry/EcalEBTrigPrimAlgos

@cmsbuild, @rekovic, @mulhearn, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 7, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20400/console Started: 2017/06/07 15:06

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19121/20400/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1703 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1837683
  • DQMHistoTests: Total failures: 38929
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1798581
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 8, 2017

+1

@davidlange6 davidlange6 merged commit bb9c412 into cms-sw:master Jun 8, 2017
@Teemperor Teemperor deleted the IncludeMessageLoggerInEcalEBTrigPrimTestAlgo.h branch December 19, 2017 08:47
@Teemperor Teemperor restored the IncludeMessageLoggerInEcalEBTrigPrimTestAlgo.h branch December 19, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants