Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consumes validation tracker hits #1913

Merged
merged 6 commits into from Jan 15, 2014

Conversation

diguida
Copy link
Contributor

@diguida diguida commented Dec 20, 2013

Consumes fix for the following modules in Validation/TrackerHits:
TrackerHitAnalyzer
TrackerHitProducer
Tested with whiteRabbit.py, workflow 3.
GitHub warns it can merge automatically, I suppose because of
306fa5e

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @diguida for CMSSW_7_0_X.

Fix consumes validation tracker hits

It involves the following packages:

Validation/TrackerHits

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @eliasron can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@ghost
Copy link

ghost commented Jan 7, 2014

@diguida Can you please rebase?

@diguida
Copy link
Contributor Author

diguida commented Jan 9, 2014

Hi @Degano
Will do it by tomorrow morning (following a course at CERN right now).
Thanks

Salvatore Di Guida added 6 commits January 15, 2014 13:01
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
…kerHitAnalyzer.

Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
…kerHitProducer.

Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
@diguida
Copy link
Contributor Author

diguida commented Jan 15, 2014

Hi!
I have rebased on top of the tip of 7_0_X branch.

@cmsbuild
Copy link
Contributor

Pull request #1913 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@diguida
Copy link
Contributor Author

diguida commented Jan 15, 2014

Tested with whiteRabbit, workflow3, successful.

@deguio
Copy link
Contributor

deguio commented Jan 15, 2014

+1
thanks. then I just approve it.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

1 similar comment
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@davidlange6
Copy link
Contributor

+1

ktf added a commit that referenced this pull request Jan 15, 2014
…Hits

Consumes migration -- Validation/TrackerHits
@ktf ktf merged commit 8e83c6e into cms-sw:CMSSW_7_0_X Jan 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants