Fireworks table entries and tooltips for CSCDetId

[alja]

Pull request has two parts:

Fix bug in reco parser in checking of validity of function: https://hypernews.cern.ch/HyperNews/CMS/get/sw-develtools/1964.html

Second part are changes in Fireworks -- predefined table entries and auto-generated tooltips which depend on bugfix in reco parser.

Request for change was by @namapane .

[alja]

+1

I have run unittests in CommonTools/Utils. No errors reported.

[cmsbuild]

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_0_X.

Fireworks table entries and tooltips for CSCDetId

It involves the following packages:

CommonTools/Utils
Fireworks/Core

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @vadler can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

[alja]

@gpetruc please watch this thread too.

[vadler]

@alja : It has nothing to do with this topic, but I get the following, when running the tests for Fireworks/Core:

===== Test "TestFireworksCore" ====
Running 8 test cases...
<config name="top" version="1">
 <config name="first" version="1">
   <string>1.0</string>
 </config>
</config>
Info: Writing to file testConfig...
Error in <TROOT::LoadMacro>: macro doesNotExist not found in path .:./macros:/afs/cern.ch/cms/slc6_amd64_gcc481/lcg/root/5.34.10-cms/macros
<config name="top" version="1">
 <config name="comp" version="1">
  <config name="d1" version="0">
    <string>10</string>
  </config>
  <config name="d2" version="0">
    <string>11</string>
  </config>
 </config>
</config>

*** No errors detected

^^^^ End Test TestFireworksCore ^^^^

"No errors detected" is not really true, is it?

[alja]

@vadler Thanks for the notice. I will look at the error.

[vadler]

@alja : Since it is unrelated, I do not consider this a show stopper.

[vadler]

+1

[alja]

I have just looked at the test. The test in https://github.com/alja/cmssw/blob/CMSSW_7_0_X/Fireworks/Core/test/unittest_fwconfiguration.cc#L133 checks catching of an exception for non-existing configuration file with name 'doesNotExist'.
It is very confusing output. I will try to improve it.

[vadler]

I see. So the errors are actually successes.

[alja]

@vadler I have improved the test in #1944

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1914/1894/summary.html

[slava77]

working on it
(since the jenkins tests have expired, will rerun locally)

[ktf]

@slava77 you can also ask to run the test again to @Degano or @nclopezo.

[nclopezo]

Hi,

I queued the tests again for this pull request on jenkins, but the queue is really busy right now, it should take some time for the tests to start.

[ktf]

can you check why the queue is so full?

[nclopezo]

it is full of IB builds

[slava77]

+1

tested 42c5175 in CMSSW_7_0_X_2014-01-10-1400 (sign294)
No diffs in reco (not surprising)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IBs unless changes (tests are also fine). @ktf can you please take care of it?

[davidlange6]

+1