Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating T(IB|OB|ID|EC)DetId types in RecoMuon/TrackerSeedGenerator #19148

Merged
merged 3 commits into from Jun 14, 2017
Merged

Deprecating T(IB|OB|ID|EC)DetId types in RecoMuon/TrackerSeedGenerator #19148

merged 3 commits into from Jun 14, 2017

Conversation

OlivierBondu
Copy link
Contributor

cc @alesaggio @vidalm @pieterdavid

Removing the deprecated
DataFormats/SiStripDetId/interface/T(IB|OB|ID|EC)DetId.h

and replacing it with
DataFormats/TrackerCommon/interface/TrackerTopology.h

@cmsbuild cmsbuild added this to the CMSSW_9_2_X milestone Jun 8, 2017
@OlivierBondu OlivierBondu mentioned this pull request Jun 8, 2017
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2017

A new Pull Request was created by @OlivierBondu (Olivier Bondu) for master.

It involves the following packages:

RecoMuon/TrackerSeedGenerator

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @jhgoh, @echapon, @calderona, @HuguesBrun, @battibass, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jun 8, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20435/console Started: 2017/06/08 18:37

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2017

+1
Tested at: 66c99ce
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19148/20435/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6bec4f7
643a6fe
3deb40f
e933dfd
b517a6f
241b8dd
a23853a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19148/20435/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19148/20435/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19148/20435/summary.html

Comparison Summary:

  • You potentially added 23 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1867702
  • DQMHistoTests: Total failures: 49228
  • DQMHistoTests: Total nulls: 390
  • DQMHistoTests: Total successes: 1817911
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jun 9, 2017

@cmsbuild please test
too many extra merges were used in the last test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20465/console Started: 2017/06/09 17:30

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

+1
Tested at: 66c99ce
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19148/20465/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

Pull request #19148 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

@OlivierBondu
Copy link
Contributor Author

Hi, sorry for the delay, I updated to const TrackerTopology *tTopo, let me know of any other comment!

Thanks,

@slava77
Copy link
Contributor

slava77 commented Jun 13, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 13, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20524/console Started: 2017/06/13 14:17

@cmsbuild
Copy link
Contributor

+1
Tested at: f0c67f4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19148/20524/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
bd4d843
935933d
be11492
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19148/20524/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19148/20524/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19148/20524/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 41 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1817858
  • DQMHistoTests: Total failures: 20215
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1797477
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@slava77 slava77 mentioned this pull request Jun 13, 2017
Merged
@slava77
Copy link
Contributor

slava77 commented Jun 13, 2017

+1

for #19148 f0c67f4

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 392e614 into cms-sw:master Jun 14, 2017
@OlivierBondu OlivierBondu deleted the RecoMuon_TrackerSeedGenerator_cmssw branch June 14, 2017 07:47
@mmusich
Copy link
Contributor

mmusich commented Jun 21, 2017

tracked at #19398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlange6 davidlange6 davidlange6 left review comments

Assignees
No one assigned
Labels
comparison-available fully-signed orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_2_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@OlivierBondu @cmsbuild @slava77 @davidlange6 @boudoul @mmusich