HGCal clustering: label border hits with rho = rho_b as Halo instead of core #19149
Conversation
|
A new Pull Request was created by @clelange (Clemens Lange) for master. It involves the following packages: RecoLocalCalo/HGCalRecAlgos @perrotta, @cmsbuild, @slava77, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
| @@ -359,7 +359,7 @@ int HGCalImagingAlgo::findAndAssignClusters(std::vector<KDNode> &nd,KDTree &lp, | |||
| if(flag_isolated) nd[i].data.isBorder = true; //the hit is more than delta_c from any of its brethren | |||
| } | |||
| //check if this border hit has density larger than the current rho_b and update | |||
| if(nd[i].data.isBorder && rho_b[ci] < nd[i].data.rho) | |||
| if(nd[i].data.isBorder && rho_b[ci] <= nd[i].data.rho) | |||
| rho_b[ci] = nd[i].data.rho; | |||
There was a problem hiding this comment.
I'm somehow missing how an additional (incremental to what it was before)
if (rho_b[ci] == nd[i].data.rho) rho_b[ci] = nd[i].data.rho;
can change anything (note that rho_b is just a simple vector of doubles, so no possible difference after full assignment if there is an equality)
Please clarify.
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
@slava77 Yes, you are very right. Thank you for catching that. We had a miscommunication and had changed the wrong line. Apologies. I've fixed that now. Can you trigger the tests again, please? |
|
please test |
|
The tests are being triggered in jenkins. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
+1 |
|
+1 |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
There was a typo in one of the if statements, which had been there a long time. After fixing the overall clustering in the previous pull request #18236, this is just a minor correction. The effect is documented in 2-5 in
https://indico.cern.ch/event/644587/contributions/2619127/attachments/1471418/2276984/hgc_cluster_issues_v2.pdf